[Erp5-dev] [PATCH] ListBox filtered notification todo support domain selection write tests

[Vera Kurpas]

Hi Kazuhiko!

Boris asked me to explain the purpose of this patch.
Our erp5 users like to see all items in listbox by default. And the
question was: how the user can understand that there are not all items
in listbox because the items were filtered?

The result of this patch: if there are not all items in listbox the
inscription !filtered! appears. The patch is not ready because the
inscription does not appear if the listbox is filtered by Report Tree or
Domain Tree. But we don't use Report Tree and Domain Tree and our users
are happy :)

Later we will write functional tests. We didn't expect that you commit
the patch, we just sent it because think it is high importance
functionality.

Vera

В Вт., 20/12/2011 в 14:27 +0100, Kazuhiko Shiozaki пишет:
> Hi Boris,
> 
> On 19/12/2011 19:19, Boris Kocherov wrote:
> > ---
> >  .../erp5_xhtml_style/ListBox_asHTML.xml            |    1 +
> >  .../erp5_xhtml_style/ListBox_asHTMLLibrary.xml     |   14 +++++++-
> >  .../erp5_xhtml_style/erp5_listbox.css.xml          |    6 +++
> >  product/ERP5Form/ListBox.py                        |   34 +++++++++++++++----
> >  product/ERP5Form/Selection.py                      |    2 +-
> >  5 files changed, 47 insertions(+), 10 deletions(-)
> 
> Thanks for your patch.
> 
> Before merging, could you provide us more detail about this patch, like
> the purpose of this patch, which problem will be solved by this patch
> etc. please ?
> 
> And also functional tests to test the new feature are required,
> especially for listbox rendering changes like this patch.
> 
> Thanks in advance.
> 
> Best regards,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: filtered.jpg
Type: image/jpeg
Size: 17695 bytes
Desc: not available
URL: <http://mail.tiolive.com/pipermail/erp5-dev/attachments/20111220/829b2e0b/attachment.jpg>