[Erp5-dev] [PATCH] ListBox filtered notification todo support domain selection write tests

Kazuhiko Shiozaki kazuhiko at nexedi.com
Tue Dec 20 14:27:14 CET 2011


Hi Boris,

On 19/12/2011 19:19, Boris Kocherov wrote:
> ---
>  .../erp5_xhtml_style/ListBox_asHTML.xml            |    1 +
>  .../erp5_xhtml_style/ListBox_asHTMLLibrary.xml     |   14 +++++++-
>  .../erp5_xhtml_style/erp5_listbox.css.xml          |    6 +++
>  product/ERP5Form/ListBox.py                        |   34 +++++++++++++++----
>  product/ERP5Form/Selection.py                      |    2 +-
>  5 files changed, 47 insertions(+), 10 deletions(-)

Thanks for your patch.

Before merging, could you provide us more detail about this patch, like
the purpose of this patch, which problem will be solved by this patch
etc. please ?

And also functional tests to test the new feature are required,
especially for listbox rendering changes like this patch.

Thanks in advance.

Best regards,
-- 
Kazuhiko Shiozaki, Nexedi SA Senior Consultant
Nexedi: Consulting and Development of Free / Open Source Software
http://www.nexedi.com
ERP5: Full Featured High End Open Source ERP
http://www.erp5.com
ERP5 Wiki: Developer Zone for ERP5 Community
http://www.erp5.org



More information about the Erp5-dev mailing list