[Neo-report] r1935 vincent - /trunk/neo/storage/database/mysqldb.py

nobody at svn.erp5.org nobody at svn.erp5.org
Wed Mar 10 16:52:20 CET 2010


Author: vincent
Date: Wed Mar 10 16:52:18 2010
New Revision: 1935

Log:
Extract the code to split up trans.oids column into a oid list.

Modified:
    trunk/neo/storage/database/mysqldb.py

Modified: trunk/neo/storage/database/mysqldb.py
==============================================================================
--- trunk/neo/storage/database/mysqldb.py [iso-8859-1] (original)
+++ trunk/neo/storage/database/mysqldb.py [iso-8859-1] Wed Mar 10 16:52:18 2010
@@ -28,6 +28,15 @@
 from neo import util
 
 LOG_QUERIES = False
+
+def splitOIDField(tid, oids):
+    if (len(oids) % 8) != 0 or len(oids) == 0:
+        raise DatabaseFailure('invalid oids for tid %x' % tid)
+    oid_list = []
+    append = oid_list.append
+    for i in xrange(0, len(oids), 8):
+        append(oids[i:i+8])
+    return oid_list
 
 class MySQLDatabaseManager(DatabaseManager):
     """This class manages a database on MySQL."""
@@ -425,11 +434,7 @@
         self.commit()
         if r:
             oids, user, desc, ext, packed = r[0]
-            if (len(oids) % 8) != 0 or len(oids) == 0:
-                raise DatabaseFailure('invalid oids for tid %x' % tid)
-            oid_list = []
-            for i in xrange(0, len(oids), 8):
-                oid_list.append(oids[i:i+8])
+            oid_list = splitOIDField(tid, oids)
             return oid_list, user, desc, ext, bool(packed)
         return None
 





More information about the Neo-report mailing list