[Neo-report] r1793 gregory - /trunk/neo/client/Storage.py

[nobody at svn.erp5.org]

Author: gregory
Date: Fri Feb 19 09:45:44 2010
New Revision: 1793

Log:
Make Storage.close() a no-op.

Behaviour is not defined for NEO but shutting down the client side seems
really bad (close is aliased to __del__).
Move no-op methods (close & cleanup) at file end, with not implemented ones.

Modified:
    trunk/neo/client/Storage.py

Modified: trunk/neo/client/Storage.py
==============================================================================
--- trunk/neo/client/Storage.py [iso-8859-1] (original)
+++ trunk/neo/client/Storage.py [iso-8859-1] Fri Feb 19 09:45:44 2010
@@ -37,14 +37,6 @@
             return self.app.load(oid=oid)
         except NEOStorageNotFoundError:
             raise POSException.POSKeyError(oid)
-
-    def close(self):
-        return self.app.close()
-
-    def cleanup(self):
-        # Used in unit tests to remove local database files.
-        # We have no such thing, so make this method a no-op.
-        pass
 
     def new_oid(self):
         if self._is_read_only:
@@ -154,3 +146,15 @@
     def set_max_oid(self, possible_new_max_oid):
         # seems used only by FileStorage
         raise NotImplementedError
+
+    def cleanup(self):
+        # Used in unit tests to remove local database files.
+        # We have no such thing, so make this method a no-op.
+        pass
+
+    def close(self):
+        # The purpose of this method is unclear, the NEO implementation may
+        # stop the client node or ask the primary master to shutdown/freeze the
+        # cluster. For now make this a no-op.
+        pass
+