[Erp5-report] r44633 vincent - /erp5/trunk/products/ERP5/Tool/DomainTool.py

nobody at svn.erp5.org nobody at svn.erp5.org
Fri Mar 25 17:10:45 CET 2011


Author: vincent
Date: Fri Mar 25 17:10:44 2011
New Revision: 44633

URL: http://svn.erp5.org?rev=44633&view=rev
Log:
Micro optimisation as I read code.

Factorise access to extend and get[Acquired]CategoryMembershipList accessor.

Modified:
    erp5/trunk/products/ERP5/Tool/DomainTool.py

Modified: erp5/trunk/products/ERP5/Tool/DomainTool.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Tool/DomainTool.py?rev=44633&r1=44632&r2=44633&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Tool/DomainTool.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Tool/DomainTool.py [utf8] Fri Mar 25 17:10:44 2011
@@ -177,15 +177,14 @@ class DomainTool(BaseTool):
         else:
           category_list = context.getCategoryList()
       else:
-        category_list = []
         if acquired:
-          for tested_base_category in tested_base_category_list:
-            category_list.extend(
-                context.getAcquiredCategoryMembershipList(tested_base_category, base=1))
+          getter = context.getAcquiredCategoryMembershipList
         else:
-          for tested_base_category in tested_base_category_list:
-            category_list.extend(
-                context.getCategoryMembershipList(tested_base_category, base=1))
+          getter = context.getCategoryMembershipList
+        category_list = []
+        extend = category_list.extend
+        for tested_base_category in tested_base_category_list:
+          extend(getter(tested_base_category, base=1))
 
       if tested_base_category_list != []:
         preferred_predicate_category_list = portal_preferences.getPreferredPredicateCategoryList()



More information about the Erp5-report mailing list