[Erp5-report] r44567 leonardo - /erp5/trunk/products/ERP5/Document/UnifySolver.py

nobody at svn.erp5.org nobody at svn.erp5.org
Thu Mar 24 17:08:41 CET 2011


Author: leonardo
Date: Thu Mar 24 17:08:41 2011
New Revision: 44567

URL: http://svn.erp5.org?rev=44567&view=rev
Log:
Add XXX comment

Modified:
    erp5/trunk/products/ERP5/Document/UnifySolver.py

Modified: erp5/trunk/products/ERP5/Document/UnifySolver.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/UnifySolver.py?rev=44567&r1=44566&r2=44567&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/UnifySolver.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/UnifySolver.py [utf8] Thu Mar 24 17:08:41 2011
@@ -79,6 +79,11 @@ class UnifySolver(AcceptSolver):
     simulation_movement_list = []
     for sub_movement in movement.getMovementList():
       if sub_movement.hasProperty(solved_property):
+        # XXX-Leo, what if there is a sub_movement that doesn't have the
+        # property, but has a "parent" that DOES have the property and
+        # that parent is not 'movement'? Perhaps we should check instead if
+        # self._getActualTargetMovement(sub_movement,solved_property)==movement
+        # before considering its related simulation movements for inclusion...
         continue
       for simulation_movement in sub_movement.getDeliveryRelatedValueList():
         simulation_movement_list.append(simulation_movement)



More information about the Erp5-report mailing list