[Erp5-report] r43987 luke - in /erp5/trunk/bt5/vifib_slap: WorkflowTemplateItem/portal_work...

[nobody at svn.erp5.org]

Author: luke
Date: Fri Mar  4 16:46:01 2011
New Revision: 43987

URL: http://svn.erp5.org?rev=43987&view=rev
Log:
- bulletproof: try really hard to deliver any packing list and do it in safe way, by checking if transition is really possible

Modified:
    erp5/trunk/bt5/vifib_slap/WorkflowTemplateItem/portal_workflow/slap_interaction_workflow/scripts/SalePackingList_markComputerPartitionFree.xml
    erp5/trunk/bt5/vifib_slap/bt/revision

Modified: erp5/trunk/bt5/vifib_slap/WorkflowTemplateItem/portal_workflow/slap_interaction_workflow/scripts/SalePackingList_markComputerPartitionFree.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/vifib_slap/WorkflowTemplateItem/portal_workflow/slap_interaction_workflow/scripts/SalePackingList_markComputerPartitionFree.xml?rev=43987&r1=43986&r2=43987&view=diff
==============================================================================
--- erp5/trunk/bt5/vifib_slap/WorkflowTemplateItem/portal_workflow/slap_interaction_workflow/scripts/SalePackingList_markComputerPartitionFree.xml [utf8] (original)
+++ erp5/trunk/bt5/vifib_slap/WorkflowTemplateItem/portal_workflow/slap_interaction_workflow/scripts/SalePackingList_markComputerPartitionFree.xml [utf8] Fri Mar  4 16:46:01 2011
@@ -75,8 +75,12 @@ for sale_packing_list_line in sale_packi
       default_aggregate_uid=software_instance.getUid(),\n
       simulation_state=NegatedQuery(Query(simulation_state="delivered")),\n
       ):\n
-      if sale_packing_list_line.getSimulationState() != \'delivered\':\n
-        sale_packing_list_line.getParentValue().deliver()\n
+      if sale_packing_list.getPortalObject().portal_workflow.isTransitionPossible(sale_packing_list, \'start\'):\n
+        sale_packing_list.start()\n
+      if sale_packing_list.getPortalObject().portal_workflow.isTransitionPossible(sale_packing_list, \'stop\'):\n
+        sale_packing_list.stop()\n
+      if sale_packing_list.getPortalObject().portal_workflow.isTransitionPossible(sale_packing_list, \'deliver\'):\n
+        sale_packing_list.deliver()\n
 \n
     # Remove unused open sale order line\n
     subscription_item = sale_packing_list_line.getAggregateValue(portal_type="Hosting Subscription")\n

Modified: erp5/trunk/bt5/vifib_slap/bt/revision
URL: http://svn.erp5.org/erp5/trunk/bt5/vifib_slap/bt/revision?rev=43987&r1=43986&r2=43987&view=diff
==============================================================================
--- erp5/trunk/bt5/vifib_slap/bt/revision [utf8] (original)
+++ erp5/trunk/bt5/vifib_slap/bt/revision [utf8] Fri Mar  4 16:46:01 2011
@@ -1 +1 @@
-352
\ No newline at end of file
+356
\ No newline at end of file