[Erp5-report] r42964 nicolas.dumazet - /erp5/trunk/products/ERP5/Document/Person.py

nobody at svn.erp5.org nobody at svn.erp5.org
Thu Feb 3 09:07:50 CET 2011


Author: nicolas.dumazet
Date: Thu Feb  3 09:07:50 2011
New Revision: 42964

URL: http://svn.erp5.org?rev=42964&view=rev
Log:
it does not make sense to override the public setter, as the private one can be
called directly (with edit() for instance) and override the reference check that
we specifically wanted to do.

This fixes testERP5Security test failures

Modified:
    erp5/trunk/products/ERP5/Document/Person.py

Modified: erp5/trunk/products/ERP5/Document/Person.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/Person.py?rev=42964&r1=42963&r2=42964&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/Person.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/Person.py [utf8] Thu Feb  3 09:07:50 2011
@@ -156,8 +156,7 @@ class Person(EncryptedPasswordMixin, XML
       if self.getLastName(): name_list.append(self.getLastName())
       if name_list: self._setTitle(' '.join(name_list))
 
-    security.declareProtected('Manage users', 'setReference')
-    def setReference(self, value):
+    def _setReference(self, value):
       """
         Set the user id. This method is defined explicitly, because:
 
@@ -200,7 +199,7 @@ class Person(EncryptedPasswordMixin, XML
         else:
           transactional_variable[tag] = None
 
-      self._setReference(value)
+      self._baseSetReference(value)
       self.reindexObject(activate_kw=activate_kw)
       # invalid the cache for ERP5Security
       portal_caches = portal.portal_caches



More information about the Erp5-report mailing list