[Erp5-report] r41998 nicolas - /erp5/trunk/utils/cloudooo/cloudooo/handler/ooo/application/

[nobody at svn.erp5.org]

Author: nicolas
Date: Tue Jan  4 16:19:28 2011
New Revision: 41998

URL: http://svn.erp5.org?rev=41998&view=rev
Log:
Usage of shell==True is deprecated and unsafe


Modified:
    erp5/trunk/utils/cloudooo/cloudooo/handler/ooo/application/openoffice.py

Modified: erp5/trunk/utils/cloudooo/cloudooo/handler/ooo/application/openoffice.py
URL: http://svn.erp5.org/erp5/trunk/utils/cloudooo/cloudooo/handler/ooo/application/openoffice.py?rev=41998&r1=41997&r2=41998&view=diff
==============================================================================
--- erp5/trunk/utils/cloudooo/cloudooo/handler/ooo/application/openoffice.py [utf8] (original)
+++ erp5/trunk/utils/cloudooo/cloudooo/handler/ooo/application/openoffice.py [utf8] Tue Jan  4 16:19:28 2011
@@ -98,11 +98,10 @@ class OpenOffice(Application):
 
   def _start_process(self, command, env):
     """Start OpenOffice.org process"""
-    self.process = Popen(' '.join(command),
-                      stdout=PIPE,
-                      shell=True,
-                      close_fds=True,
-                      env=env)
+    self.process = Popen(command,
+                         close_fds=True,
+                         env=env)
+    returned_code = self.process.poll()
     waitStartDaemon(self, self.timeout)
     return self._testOpenOffice(self.hostname, self.port)