[Erp5-report] r41508 jm - /erp5/trunk/products/ERP5Type/Base.py

[nobody at svn.erp5.org]

Author: jm
Date: Fri Dec 17 01:45:01 2010
New Revision: 41508

URL: http://svn.erp5.org?rev=41508&view=rev
Log:
Fix possible 'dictionary changed size during iteration' error when a BT installs a property sheet

Modified:
    erp5/trunk/products/ERP5Type/Base.py

Modified: erp5/trunk/products/ERP5Type/Base.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/Base.py?rev=41508&r1=41507&r2=41508&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/Base.py [utf8] (original)
+++ erp5/trunk/products/ERP5Type/Base.py [utf8] Fri Dec 17 01:45:01 2010
@@ -937,7 +937,9 @@ class Base( CopyContainer,
         portal_types = getToolByName(portal, 'portal_types', None)
         generated_bid = set()
         econtext = createExpressionContext(object=self, portal=portal)
-        for pid, ps in PropertySheet.__dict__.iteritems():
+        # Use 'items' instead of 'iteritems' because PropertySheet.__dict__ may
+        # be modified by another thread (that, for example, installs a BT).
+        for pid, ps in PropertySheet.__dict__.items():
           if pid[0] != '_':
             base_category_list = []
             for cat in getattr(ps, '_categories', ()):