[Erp5-report] r39353 kazuhiko - in /erp5/trunk/bt5/erp5_forge: SkinTemplateItem/portal_skin...

[nobody at svn.erp5.org]

Author: kazuhiko
Date: Tue Oct 19 17:04:28 2010
New Revision: 39353

URL: http://svn.erp5.org?rev=39353&view=rev
Log:
Skip an empty selection name that is now valid for a listbox where we don't want to store a selection.

Modified:
    erp5/trunk/bt5/erp5_forge/SkinTemplateItem/portal_skins/erp5_toolbox/SkinsTool_getDuplicateSelectionNameDict.xml
    erp5/trunk/bt5/erp5_forge/bt/change_log
    erp5/trunk/bt5/erp5_forge/bt/revision

Modified: erp5/trunk/bt5/erp5_forge/SkinTemplateItem/portal_skins/erp5_toolbox/SkinsTool_getDuplicateSelectionNameDict.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_forge/SkinTemplateItem/portal_skins/erp5_toolbox/SkinsTool_getDuplicateSelectionNameDict.xml?rev=39353&r1=39352&r2=39353&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_forge/SkinTemplateItem/portal_skins/erp5_toolbox/SkinsTool_getDuplicateSelectionNameDict.xml [utf8] (original)
+++ erp5/trunk/bt5/erp5_forge/SkinTemplateItem/portal_skins/erp5_toolbox/SkinsTool_getDuplicateSelectionNameDict.xml [utf8] Tue Oct 19 17:04:28 2010
@@ -81,7 +81,8 @@ for field_path, field in skins_tool.Zope
     if field.get_tales(\'selection_name\')!=\'\':\n
       continue\n
     selection_name = field.get_orig_value(\'selection_name\')\n
-\n
+  if selection_name == \'\':\n
+    continue\n
   selection_name_dict.setdefault(\n
          selection_name, []).append(field_path)\n
 \n

Modified: erp5/trunk/bt5/erp5_forge/bt/change_log
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_forge/bt/change_log?rev=39353&r1=39352&r2=39353&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_forge/bt/change_log [utf8] (original)
+++ erp5/trunk/bt5/erp5_forge/bt/change_log [utf8] Tue Oct 19 17:04:28 2010
@@ -1,5 +1,5 @@
 2010-10-19 Kazuhiko
-* When checking duplicated selection names, we should use get_recursive_orig_value('selection_name') instead of getRecursiveTemplateField().get_value('selection_name'), because delegation for selection_name can end at any intermediate proxy field.
+* When checking duplicated selection names, we should use get_recursive_orig_value('selection_name') instead of getRecursiveTemplateField().get_value('selection_name'), because delegation for selection_name can end at any intermediate proxy field. And skip an empty selection name that is now valid for a listbox where we don't want to store a selection.
 
 2010-10-19 yo
 * When checking duplicated selection names, skip field libraries, as they don't matter.

Modified: erp5/trunk/bt5/erp5_forge/bt/revision
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_forge/bt/revision?rev=39353&r1=39352&r2=39353&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_forge/bt/revision [utf8] (original)
+++ erp5/trunk/bt5/erp5_forge/bt/revision [utf8] Tue Oct 19 17:04:28 2010
@@ -1 +1 @@
-624
\ No newline at end of file
+625
\ No newline at end of file