[Erp5-report] r38187 yo - /erp5/trunk/products/ERP5/Document/OrderBuilder.py

[nobody at svn.erp5.org]

Author: yo
Date: Wed Sep  8 08:37:52 2010
New Revision: 38187

URL: http://svn.erp5.org?rev=38187&view=rev
Log:
Move the filtering of deliveries by a portal type from the processing code to the caller.

Modified:
    erp5/trunk/products/ERP5/Document/OrderBuilder.py

Modified: erp5/trunk/products/ERP5/Document/OrderBuilder.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/OrderBuilder.py?rev=38187&r1=38186&r2=38187&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/OrderBuilder.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/OrderBuilder.py [utf8] Wed Sep  8 08:37:52 2010
@@ -340,6 +340,11 @@ class OrderBuilder(XMLObject, Amount, Pr
         delivery_select_method = getattr(self, delivery_select_method_id)
         for brain in delivery_select_method(movement_list=movement_list):
           delivery_to_update_list.append(brain.getObject())
+
+      # Make sure that the portal type is good.
+      delivery_portal_type = self.getDeliveryPortalType()
+      delivery_to_update_list = [x for x in delivery_to_update_list \
+              if x.getPortalType() == delivery_portal_type]
     else:
       delivery_to_update_list = []
     # We do not want to update the same object more than twice in one
@@ -404,8 +409,7 @@ class OrderBuilder(XMLObject, Amount, Pr
       # a new one
       delivery_to_update_list = [
         x for x in delivery_to_update_list \
-        if x.getPortalType() == self.getDeliveryPortalType() and \
-        not self._isUpdated(x, 'delivery')]
+        if not self._isUpdated(x, 'delivery')]
       delivery, property_dict = self._findUpdatableObject(
         delivery_to_update_list, movement_group_node_list,
         divergence_list)