[Erp5-report] r37668 yo - /erp5/trunk/products/ERP5/Document/Delivery.py

[nobody at svn.erp5.org]

Author: yo
Date: Tue Aug 10 08:42:54 2010
New Revision: 37668

URL: http://svn.erp5.org?rev=37668&view=rev
Log:
Add a comment on some possible performance improvements.

Modified:
    erp5/trunk/products/ERP5/Document/Delivery.py

Modified: erp5/trunk/products/ERP5/Document/Delivery.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/Delivery.py?rev=37668&r1=37667&r2=37668&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/Delivery.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/Delivery.py [utf8] Tue Aug 10 08:42:54 2010
@@ -792,6 +792,15 @@ class Delivery(XMLObject, Immobilisation
           # once expanded, the applied_rule must be reindexed
           # because some simulation_movement may change even
           # if there are not edited (acquisition)
+          #
+          # XXX yo thinks that this is excessive. First of all, we may
+          # need to reindex simulation movements but not applied rules
+          # here. So we should skip reindexing applied rules.
+          # In addition, the policy is "copy everything required to
+          # simulation movements", so acquisitions should not matter to
+          # indexing. The only exception is the simulation state.
+          # I think, if each simulation movement remembers the previous
+          # state, we can avoid unnecessary reindexing.
           my_applied_rule.recursiveReindexObject(activate_kw=activate_kw)
         else:
           LOG("ERP5", PROBLEM,