[Erp5-report] r37015 nicolas - /erp5/trunk/products/ERP5/Tool/ContributionTool.py

nobody at svn.erp5.org nobody at svn.erp5.org
Fri Jul 9 15:00:08 CEST 2010


Author: nicolas
Date: Fri Jul  9 15:00:02 2010
New Revision: 37015

URL: http://svn.erp5.org?rev=37015&view=rev
Log:
Remove code which seems obsoleted.
There should not be any differences between external documents and others.

Modified:
    erp5/trunk/products/ERP5/Tool/ContributionTool.py

Modified: erp5/trunk/products/ERP5/Tool/ContributionTool.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Tool/ContributionTool.py?rev=37015&r1=37014&r2=37015&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Tool/ContributionTool.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Tool/ContributionTool.py [utf8] Fri Jul  9 15:00:02 2010
@@ -379,19 +379,7 @@ class ContributionTool(BaseTool):
             ('convertToBaseFormat', 'Document_tryToConvertToBaseFormat'))) \
           .discoverMetadata(file_name=name, user_login=user_login)
       else:
-        if existing_document.isExternalDocument():
-          document = existing_document
-          # If this is an external document, update its content
-          # document.activate().updateContentFromURL() # XXX I think this is no longer useful with alarms
-          # XXX - Make sure this does not increase ZODB
-          # XXX - what to do also with parameters (put again edit_kw) ?
-          # Providing some information to the use about the fact
-          # this was an existing document would also be great
-        else:
-          # We may have to implement additional revision support
-          # to support in place contribution (ie. for a given ID)
-          # but is this really useful ?
-          raise NotImplementedError
+        document = existing_document
       # Keep the document close to us - this is only useful for
       # file upload from webdav
       if not hasattr(self, '_v_document_cache'):




More information about the Erp5-report mailing list