[Erp5-report] r36542 kazuhiko - /erp5/trunk/products/ERP5/Document/Delivery.py

[nobody at svn.erp5.org]

Author: kazuhiko
Date: Wed Jun 23 16:43:58 2010
New Revision: 36542

URL: http://svn.erp5.org?rev=36542&view=rev
Log:
faster implementation of isDivergent() and getDivergentList() by calling catalog only once.

Modified:
    erp5/trunk/products/ERP5/Document/Delivery.py

Modified: erp5/trunk/products/ERP5/Document/Delivery.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/Delivery.py?rev=36542&r1=36541&r2=36542&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/Delivery.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/Delivery.py [utf8] Wed Jun 23 16:43:58 2010
@@ -353,8 +353,8 @@ class Delivery(XMLObject, Immobilisation
       ## Note that fast option was removed. Now, fast=1 is ignored.
       
       # Check if the total quantity equals the total of each simulation movement quantity
-      for movement in self.getMovementList():
-        if movement.isDivergent():
+      for simulation_movement in self._getAllRelatedSimulationMovementList():
+        if simulation_movement.isDivergent():
           return 1
       return 0
 
@@ -364,8 +364,8 @@ class Delivery(XMLObject, Immobilisation
       Return a list of messages that contains the divergences
       """
       divergence_list = []
-      for movement in self.getMovementList():
-         divergence_list.extend(movement.getDivergenceList())
+      for simulation_movement in self._getAllRelatedSimulationMovementList():
+         divergence_list.extend(simulation_movement.getDivergenceList())
       return divergence_list
 
     @UnrestrictedMethod