[Erp5-report] r36162 jm - /erp5/trunk/products/ZSQLCatalog/SQLCatalog.py

[nobody at svn.erp5.org]

Author: jm
Date: Wed Jun  9 15:09:01 2010
New Revision: 36162

URL: http://svn.erp5.org?rev=36162&view=rev
Log:
SQLCatalog: use set instead of dict without values

Modified:
    erp5/trunk/products/ZSQLCatalog/SQLCatalog.py

Modified: erp5/trunk/products/ZSQLCatalog/SQLCatalog.py
URL: http://svn.erp5.org/erp5/trunk/products/ZSQLCatalog/SQLCatalog.py?rev=36162&r1=36161&r2=36162&view=diff
==============================================================================
--- erp5/trunk/products/ZSQLCatalog/SQLCatalog.py [utf8] (original)
+++ erp5/trunk/products/ZSQLCatalog/SQLCatalog.py [utf8] Wed Jun  9 15:09:01 2010
@@ -944,23 +944,20 @@ class Catalog(Folder,
   @caching_instance_method(id='SQLCatalog.getColumnIds',
                            cache_factory='erp5_content_long')
   def _getColumnIds(self):
-    keys = {}
+    keys = set()
+    add_key = keys.add
     for table in self.getCatalogSearchTableIds():
       field_list = self._getCatalogSchema(table=table)
       for field in field_list:
-        keys[field] = None
-        keys['%s.%s' % (table, field)] = None  # Is this inconsistent ?
+        add_key(field)
+        add_key('%s.%s' % (table, field))  # Is this inconsistent ?
     for related in self.getSQLCatalogRelatedKeyList():
       related_tuple = related.split('|')
-      related_key = related_tuple[0].strip()
-      keys[related_key] = None
+      add_key(related_tuple[0].strip())
     for scriptable in self.getSQLCatalogScriptableKeyList():
       scriptable_tuple = scriptable.split('|')
-      scriptable = scriptable_tuple[0].strip()
-      keys[scriptable] = None
-    keys = keys.keys()
-    keys.sort()
-    return keys
+      add_key(scriptable_tuple[0].strip())
+    return sorted(keys)
 
   def getColumnIds(self):
     """