[Erp5-report] r35927 jerome - /erp5/trunk/products/ERP5Type/tests/

[nobody at svn.erp5.org]

Author: jerome
Date: Thu Jun  3 10:03:52 2010
New Revision: 35927

URL: http://svn.erp5.org?rev=35927&view=rev
Log:
cleanups, remove unused code and duplicate definition of getSvnRevision

Modified:
    erp5/trunk/products/ERP5Type/tests/prepareFunctionalTest.py
    erp5/trunk/products/ERP5Type/tests/runFunctionalTest.py

Modified: erp5/trunk/products/ERP5Type/tests/prepareFunctionalTest.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/tests/prepareFunctionalTest.py?rev=35927&r1=35926&r2=35927&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/tests/prepareFunctionalTest.py [utf8] (original)
+++ erp5/trunk/products/ERP5Type/tests/prepareFunctionalTest.py [utf8] Thu Jun  3 10:03:52 2010
@@ -26,13 +26,7 @@
 #
 ##############################################################################
 
-#
-# Prepare ERP5 Zelenium Test.
-#
-# usage: python runUnitTest.py --save [OPTION]... prepareFunctionalTest.py
-#
-
-import os, os.path
+import os
 import unittest
 
 from Products.ERP5Type.tests.ERP5TypeTestCase import ERP5TypeTestCase
@@ -49,25 +43,7 @@
     self.host = host
     self.port = int(port)
   
-  def getSvnRevision(self):
-    # we should get the revision of a business template, but this is good
-    # enough for now.
-    import pysvn
-    revision = pysvn.Client().info(os.path.dirname(__file__)).revision.number
-    return revision
-
-
 os.environ['erp5_tests_portal_id'] = 'erp5_portal'
-
-MSG = '''
-This "test file" is intended to be used with --save option, for use with
-runFunctionalTest.py.
-
-It will now enter an IPython prompt so you can explore the environment either
-through IPython or through the "ZServer port" reported above.
-
-Once you exit the IPython prompt, this "test" will finish.
-'''.strip()
 
 class TestZelenium(ERP5TypeTestCase):
     def getBusinessTemplateList(self):
@@ -103,9 +79,7 @@
                       runner_arguments)
       self.runner.main()
       self.runner.sendResult()
-      #print MSG
-      #import IPython.Shell
-      #IPython.Shell.IPShellEmbed('')(local_ns=locals(), global_ns=globals())
+
 
 def test_suite():
     suite = unittest.TestSuite()

Modified: erp5/trunk/products/ERP5Type/tests/runFunctionalTest.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/tests/runFunctionalTest.py?rev=35927&r1=35926&r2=35927&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/tests/runFunctionalTest.py [utf8] (original)
+++ erp5/trunk/products/ERP5Type/tests/runFunctionalTest.py [utf8] Thu Jun  3 10:03:52 2010
@@ -85,8 +85,8 @@
     try:
       opts, args = getopt.getopt(arguments,
             "hsd", ["help", "stdout", "debug",
-                   "email_to_address=", "host=", "port=", 
-                   "portal_name=", "run_only=", "user=", 
+                   "email_to_address=", "host=", "port=",
+                   "portal_name=", "run_only=", "user=",
                    "password=", "alarms=",
                    "email_subject=", "smtp_host=", "xvfb_display="] )
     except getopt.GetoptError, msg:
@@ -175,7 +175,7 @@
     os.system('%s/bin/zopectl stop' % self.instance_home)
   
   def runXvfb(self, xvfb_display):
-    pid = os.spawnlp(os.P_NOWAIT, 'Xvfb', 'Xvfb', 
+    pid = os.spawnlp(os.P_NOWAIT, 'Xvfb', 'Xvfb',
                      '-fbdir' , '%s' % self.xvfb_fbdir  ,
                      ':%s' % xvfb_display)
     display = os.environ.get('DISPLAY')
@@ -298,11 +298,9 @@
     self.unsubscribeFromTimerService()
 
   def getSvnRevision(self):
-    # get SVN revision used
+    """Get svn revision used."""
     import pysvn
-    os.chdir('%s/Products/ERP5' % self.instance_home)
-    revision = pysvn.Client().info('.').revision.number
-    return revision
+    return pysvn.Client().info(os.path.dirname(__file__)).revision.number
 
   def sendResult(self):
     result_uri = urllib2.urlopen('%s/portal_tests/TestTool_getResults' % self.portal_url).readline()