[Erp5-report] r34893 ivan - in /erp5/trunk/bt5/erp5_discussion: SkinTemplateItem/portal_ski...
nobody at svn.erp5.org
nobody at svn.erp5.org
Fri Apr 30 14:31:38 CEST 2010
Author: ivan
Date: Fri Apr 30 14:31:37 2010
New Revision: 34893
URL: http://svn.erp5.org?rev=34893&view=rev
Log:
Simplify quick new thread dialogs and make it possible for user to specify list of notified persons when creating a new thread rather than when creating a new post.
Added:
erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog/your_send_notification_text.xml
Modified:
erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_createNewDiscussionThread.xml
erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog.xml
erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog/my_classification.xml
erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog/my_description.xml
erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThread_createNewDiscussionPost.xml
erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThread_viewCreateNewDiscussionPostDialog.xml
erp5/trunk/bt5/erp5_discussion/bt/revision
Modified: erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_createNewDiscussionThread.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_createNewDiscussionThread.xml?rev=34893&r1=34892&r2=34893&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_createNewDiscussionThread.xml [utf8] (original)
+++ erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_createNewDiscussionThread.xml [utf8] Fri Apr 30 14:31:37 2010
@@ -93,6 +93,36 @@
discussion_thread.submit()\n
discussion_post.submit()\n
\n
+if send_notification_text not in (\'\', None):\n
+ # we can send notifications\n
+ email_list = []\n
+ notification_list = send_notification_text.split(\'\\r\\n\')\n
+ for notification in notification_list:\n
+ if \'@\' in notification:\n
+ # user specified an email\n
+ email_list.append(notification)\n
+ else:\n
+ # we can assume user wanted to specify Person\'s title\n
+ person_list = portal.portal_catalog(portal_type=\'Person\',\n
+ title=notification)\n
+ email_list.extend([x.getDefaultEmailText() for x in person_list])\n
+ email_from = portal.email_from_address\n
+ email_subject = "New forum post"\n
+ email_template = """\n
+\n
+New forum post has been created at this url:\n
+\n
+${url}""" \n
+ email_body = context.Base_translateString(email_template, mapping={\'url\':discussion_thread.absolute_url()})\n
+ for email_to in email_list:\n
+ mail_headers = """\n
+To: %s\n
+From: %s\n
+Subject: %s\n
+Date: %s""" %(email_to, email_from, email_subject, DateTime().rfc822())\n
+ mail_source =\'%s\\n\\n%s\' %(mail_headers, email_body)\n
+ context.MailHost.send(mail_source)\n
+\n
return discussion_thread.Base_redirect(form_id,\n
keep_items = dict(portal_status_message=context.Base_translateString(portal_status_message)))\n
</string> </value>
@@ -105,7 +135,7 @@
</item>
<item>
<key> <string>_params</string> </key>
- <value> <string>title, text_content, form_id=\'view\', predecessor=None, description=None, subject_list=None, classification=None, group_list=None, site_list=None, reference=None,**kw</string> </value>
+ <value> <string>title, text_content, form_id=\'view\', predecessor=None, description=None, subject_list=None, classification=None, group_list=None, site_list=None, send_notification_text=None, reference=None,**kw</string> </value>
</item>
<item>
<key> <string>_proxy_roles</string> </key>
@@ -131,7 +161,7 @@
<dictionary>
<item>
<key> <string>co_argcount</string> </key>
- <value> <int>10</int> </value>
+ <value> <int>11</int> </value>
</item>
<item>
<key> <string>co_varnames</string> </key>
@@ -146,6 +176,7 @@
<string>classification</string>
<string>group_list</string>
<string>site_list</string>
+ <string>send_notification_text</string>
<string>reference</string>
<string>kw</string>
<string>None</string>
@@ -161,6 +192,22 @@
<string>discussion_thread</string>
<string>discussion_post</string>
<string>portal_status_message</string>
+ <string>email_list</string>
+ <string>notification_list</string>
+ <string>_getiter_</string>
+ <string>notification</string>
+ <string>person_list</string>
+ <string>append</string>
+ <string>$append0</string>
+ <string>x</string>
+ <string>email_from</string>
+ <string>email_subject</string>
+ <string>email_template</string>
+ <string>email_body</string>
+ <string>email_to</string>
+ <string>DateTime</string>
+ <string>mail_headers</string>
+ <string>mail_source</string>
<string>dict</string>
</tuple>
</value>
@@ -182,6 +229,7 @@
<none/>
<none/>
<none/>
+ <none/>
</tuple>
</value>
</item>
Modified: erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog.xml?rev=34893&r1=34892&r2=34893&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog.xml [utf8] (original)
+++ erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog.xml [utf8] Fri Apr 30 14:31:37 2010
@@ -114,6 +114,7 @@
<value>
<list>
<string>my_subject_list</string>
+ <string>your_send_notification_text</string>
</list>
</value>
</item>
Modified: erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog/my_classification.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog/my_classification.xml?rev=34893&r1=34892&r2=34893&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog/my_classification.xml [utf8] (original)
+++ erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog/my_classification.xml [utf8] Fri Apr 30 14:31:37 2010
@@ -12,7 +12,9 @@
<item>
<key> <string>delegated_list</string> </key>
<value>
- <list/>
+ <list>
+ <string>enabled</string>
+ </list>
</value>
</item>
<item>
@@ -73,6 +75,10 @@
<value>
<dictionary>
<item>
+ <key> <string>enabled</string> </key>
+ <value> <int>0</int> </value>
+ </item>
+ <item>
<key> <string>field_id</string> </key>
<value> <string>my_classification</string> </value>
</item>
Modified: erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog/my_description.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog/my_description.xml?rev=34893&r1=34892&r2=34893&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog/my_description.xml [utf8] (original)
+++ erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog/my_description.xml [utf8] Fri Apr 30 14:31:37 2010
@@ -12,7 +12,9 @@
<item>
<key> <string>delegated_list</string> </key>
<value>
- <list/>
+ <list>
+ <string>enabled</string>
+ </list>
</value>
</item>
<item>
@@ -73,6 +75,10 @@
<value>
<dictionary>
<item>
+ <key> <string>enabled</string> </key>
+ <value> <int>0</int> </value>
+ </item>
+ <item>
<key> <string>field_id</string> </key>
<value> <string>my_description</string> </value>
</item>
Added: erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog/your_send_notification_text.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog/your_send_notification_text.xml?rev=34893&view=auto
==============================================================================
--- erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog/your_send_notification_text.xml (added)
+++ erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThreadModule_viewCreateNewDiscussionThreadDialog/your_send_notification_text.xml [utf8] Fri Apr 30 14:31:37 2010
@@ -1,0 +1,125 @@
+<?xml version="1.0"?>
+<ZopeData>
+ <record id="1" aka="AAAAAAAAAAE=">
+ <pickle>
+ <tuple>
+ <global name="ProxyField" module="Products.ERP5Form.ProxyField"/>
+ <tuple/>
+ </tuple>
+ </pickle>
+ <pickle>
+ <dictionary>
+ <item>
+ <key> <string>delegated_list</string> </key>
+ <value>
+ <list>
+ <string>description</string>
+ <string>editable</string>
+ <string>title</string>
+ </list>
+ </value>
+ </item>
+ <item>
+ <key> <string>id</string> </key>
+ <value> <string>your_send_notification_text</string> </value>
+ </item>
+ <item>
+ <key> <string>message_values</string> </key>
+ <value>
+ <dictionary>
+ <item>
+ <key> <string>external_validator_failed</string> </key>
+ <value> <string>The input failed the external validator.</string> </value>
+ </item>
+ </dictionary>
+ </value>
+ </item>
+ <item>
+ <key> <string>overrides</string> </key>
+ <value>
+ <dictionary>
+ <item>
+ <key> <string>field_id</string> </key>
+ <value> <string></string> </value>
+ </item>
+ <item>
+ <key> <string>form_id</string> </key>
+ <value> <string></string> </value>
+ </item>
+ <item>
+ <key> <string>target</string> </key>
+ <value> <string></string> </value>
+ </item>
+ </dictionary>
+ </value>
+ </item>
+ <item>
+ <key> <string>tales</string> </key>
+ <value>
+ <dictionary>
+ <item>
+ <key> <string>display_width</string> </key>
+ <value> <string></string> </value>
+ </item>
+ <item>
+ <key> <string>editable</string> </key>
+ <value> <string></string> </value>
+ </item>
+ <item>
+ <key> <string>field_id</string> </key>
+ <value> <string></string> </value>
+ </item>
+ <item>
+ <key> <string>form_id</string> </key>
+ <value> <string></string> </value>
+ </item>
+ <item>
+ <key> <string>target</string> </key>
+ <value> <string></string> </value>
+ </item>
+ <item>
+ <key> <string>title</string> </key>
+ <value> <string></string> </value>
+ </item>
+ </dictionary>
+ </value>
+ </item>
+ <item>
+ <key> <string>values</string> </key>
+ <value>
+ <dictionary>
+ <item>
+ <key> <string>description</string> </key>
+ <value> <string>Use this text area to specify email addresses or persons\' titles which should receive notification about this post\'s creation. Each on a new line. Wildcards like \'%\' are supported.</string> </value>
+ </item>
+ <item>
+ <key> <string>display_width</string> </key>
+ <value> <int>40</int> </value>
+ </item>
+ <item>
+ <key> <string>editable</string> </key>
+ <value> <int>1</int> </value>
+ </item>
+ <item>
+ <key> <string>field_id</string> </key>
+ <value> <string>my_text_area_field</string> </value>
+ </item>
+ <item>
+ <key> <string>form_id</string> </key>
+ <value> <string>Base_viewFieldLibrary</string> </value>
+ </item>
+ <item>
+ <key> <string>target</string> </key>
+ <value> <string>Click to edit the target</string> </value>
+ </item>
+ <item>
+ <key> <string>title</string> </key>
+ <value> <string>Notification list</string> </value>
+ </item>
+ </dictionary>
+ </value>
+ </item>
+ </dictionary>
+ </pickle>
+ </record>
+</ZopeData>
Modified: erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThread_createNewDiscussionPost.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThread_createNewDiscussionPost.xml?rev=34893&r1=34892&r2=34893&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThread_createNewDiscussionPost.xml [utf8] (original)
+++ erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThread_createNewDiscussionPost.xml [utf8] Fri Apr 30 14:31:37 2010
@@ -74,35 +74,6 @@
# depending on security model Post can be submited for review\n
portal_status_message = "New post created."\n
discussion_post.release()\n
-if send_notification_text not in (\'\', None):\n
- # we can send notifications\n
- email_list = []\n
- notification_list = send_notification_text.split(\'\\r\\n\')\n
- for notification in notification_list:\n
- if \'@\' in notification:\n
- # user specified an email\n
- email_list.append(notification)\n
- else:\n
- # we can assume user wanted to specify Person\'s title\n
- person_list = portal.portal_catalog(portal_type=\'Person\',\n
- title=notification)\n
- email_list.extend([x.getDefaultEmailText() for x in person_list])\n
- email_from = portal.email_from_address\n
- email_subject = "New forum post"\n
- email_template = """\n
-\n
-New forum post has been created at this url:\n
-\n
-${url}""" \n
- email_body = context.Base_translateString(email_template, mapping={\'url\':discussion_post.absolute_url()})\n
- for email_to in email_list:\n
- mail_headers = """\n
-To: %s\n
-From: %s\n
-Subject: %s\n
-Date: %s""" %(email_to, email_from, email_subject, DateTime().rfc822())\n
- mail_source =\'%s\\n\\n%s\' %(mail_headers, email_body)\n
- context.MailHost.send(mail_source)\n
\n
return context.Base_redirect(form_id,\n
keep_items = dict(portal_status_message=context.Base_translateString(portal_status_message)))\n
@@ -116,7 +87,7 @@
</item>
<item>
<key> <string>_params</string> </key>
- <value> <string>title, text_content, form_id=\'view\', send_notification_text=None, predecessor=None,**kw</string> </value>
+ <value> <string>title, text_content, form_id=\'view\', predecessor=None,**kw</string> </value>
</item>
<item>
<key> <string>_proxy_roles</string> </key>
@@ -145,7 +116,7 @@
<dictionary>
<item>
<key> <string>co_argcount</string> </key>
- <value> <int>5</int> </value>
+ <value> <int>4</int> </value>
</item>
<item>
<key> <string>co_varnames</string> </key>
@@ -154,7 +125,6 @@
<string>title</string>
<string>text_content</string>
<string>form_id</string>
- <string>send_notification_text</string>
<string>predecessor</string>
<string>kw</string>
<string>DateTime</string>
@@ -166,22 +136,6 @@
<string>language</string>
<string>discussion_post</string>
<string>portal_status_message</string>
- <string>None</string>
- <string>email_list</string>
- <string>notification_list</string>
- <string>_getiter_</string>
- <string>notification</string>
- <string>person_list</string>
- <string>append</string>
- <string>$append0</string>
- <string>x</string>
- <string>email_from</string>
- <string>email_subject</string>
- <string>email_template</string>
- <string>email_body</string>
- <string>email_to</string>
- <string>mail_headers</string>
- <string>mail_source</string>
<string>dict</string>
</tuple>
</value>
@@ -196,7 +150,6 @@
<value>
<tuple>
<string>view</string>
- <none/>
<none/>
</tuple>
</value>
Modified: erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThread_viewCreateNewDiscussionPostDialog.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThread_viewCreateNewDiscussionPostDialog.xml?rev=34893&r1=34892&r2=34893&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThread_viewCreateNewDiscussionPostDialog.xml [utf8] (original)
+++ erp5/trunk/bt5/erp5_discussion/SkinTemplateItem/portal_skins/erp5_discussion/DiscussionThread_viewCreateNewDiscussionPostDialog.xml [utf8] Fri Apr 30 14:31:37 2010
@@ -100,7 +100,6 @@
<value>
<list>
<string>your_title</string>
- <string>your_send_notification_text</string>
</list>
</value>
</item>
Modified: erp5/trunk/bt5/erp5_discussion/bt/revision
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_discussion/bt/revision?rev=34893&r1=34892&r2=34893&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_discussion/bt/revision [utf8] (original)
+++ erp5/trunk/bt5/erp5_discussion/bt/revision [utf8] Fri Apr 30 14:31:37 2010
@@ -1,1 +1,1 @@
-46
+47
More information about the Erp5-report
mailing list