[Erp5-report] r34739 fabien - in /erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style: Skin...

[nobody at svn.erp5.org]

Author: fabien
Date: Fri Apr 23 12:06:19 2010
New Revision: 34739

URL: http://svn.erp5.org?rev=34739&view=rev
Log:
remove the use of id as it is useless (everything can be done using field type and class) and make html page not valid. It's a bad habit to use id, in most of the case, class should be used instead.

Modified:
    erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/erp5.js.xml
    erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/form_dialog.xml
    erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/form_render.xml
    erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/bt/revision

Modified: erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/erp5.js.xml
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/erp5.js.xml?rev=34739&r1=34738&r2=34739&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/erp5.js.xml [utf8] (original)
+++ erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/erp5.js.xml [utf8] Fri Apr 23 12:06:19 2010
@@ -151,10 +151,10 @@
 \n
 function matchChunk(string, separator, chunk_value) {\n
   if (string != null) {\n
-    var id_chunks = string.split(separator);\n
+    var chunk_list = string.split(separator);\n
     var i;\n
-    for (i = 0; i < id_chunks.length; i++) {\n
-      if (id_chunks[i] == chunk_value)\n
+    for (i = 0; i < chunk_list.length; i++) {\n
+      if (chunk_list[i] == chunk_value)\n
         return true;\n
     }\n
   }\n
@@ -163,12 +163,12 @@
 \n
 function matchLeftFieldset(element) {\n
   return (element.tagName == "FIELDSET") &&\n
-          matchChunk(element.id, \'_\', "left");\n
+          matchChunk(element.className, \' \', "left");\n
 }\n
 \n
 function matchRightFieldset(element, ignored) {\n
   if ((element.tagName == "FIELDSET") &&\n
-       matchChunk(element.id, \'_\', "right"))\n
+       matchChunk(element.className, \' \', "right"))\n
     return 7; /* End row, table and use element */\n
   return 0;\n
 }\n

Modified: erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/form_dialog.xml
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/form_dialog.xml?rev=34739&r1=34738&r2=34739&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/form_dialog.xml [utf8] (original)
+++ erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/form_dialog.xml [utf8] Fri Apr 23 12:06:19 2010
@@ -113,8 +113,7 @@
               <tal:block tal:repeat="group group_list">\n
                 <tal:block tal:define="gid    group/gid">\n
                   <fieldset tal:condition="python: \'hidden\' not in gid and \'bottom\' not in gid and \'head\' not in gid"\n
-                            tal:attributes="class gid;\n
-                            id    python: \'fieldset_\' + gid.replace(\' \', \'_\');">\n
+                    tal:attributes="class gid;">\n
                     <legend tal:content="group/gtitle" class="group_title" />\n
                     <tal:block tal:repeat="field python: form.get_fields_in_group(group[\'goid\'])">\n
                       <tal:block metal:use-macro="field_render" />\n
@@ -154,7 +153,8 @@
 \n
     </tal:block>\n
   </tal:block>\n
-</tal:block>
+</tal:block>\n
+
 
 ]]></string> </value>
         </item>

Modified: erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/form_render.xml
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/form_render.xml?rev=34739&r1=34738&r2=34739&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/form_render.xml [utf8] (original)
+++ erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/form_render.xml [utf8] Fri Apr 23 12:06:19 2010
@@ -79,8 +79,7 @@
       <tal:block tal:repeat="group group_list">\n
         <tal:block tal:define="gid     group/gid;">\n
           <fieldset tal:condition="python: gid.find(\'hidden\') &lt; 0"\n
-                    tal:attributes="class python:gid + test(request.get(\'editable_mode\', 0), \' editable\', \' viewable\');\n
-                                    id    python: \'fieldset_%s\' % (gid.replace(\' \', \'_\'), );">\n
+              tal:attributes="class python:gid + test(request.get(\'editable_mode\', 0), \' editable\', \' viewable\');">\n
             <legend i18n:translate="" i18n:domain="ui" tal:condition="group/gtitle" tal:content="group/gtitle" class="group_title"></legend>\n
             <tal:block tal:repeat="field python: form.get_fields_in_group(group[\'goid\'])">\n
               <tal:block metal:use-macro="field_render" />\n

Modified: erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/bt/revision
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/bt/revision?rev=34739&r1=34738&r2=34739&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/bt/revision [utf8] (original)
+++ erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/bt/revision [utf8] Fri Apr 23 12:06:19 2010
@@ -1,1 +1,1 @@
-930
+931