[Erp5-report] r33975 rafael - in /erp5/trunk/utils/erp5.recipe.mysqlserver: ./ src/erp5/rec...

[nobody at svn.erp5.org]

Author: rafael
Date: Tue Mar 23 01:06:04 2010
New Revision: 33975

URL: http://svn.erp5.org?rev=33975&view=rev
Log:
Bug Fix, The mysql_install_db was not running in appropriate way making this recipe not working.

Thanks to Lucas for report it.

Modified:
    erp5/trunk/utils/erp5.recipe.mysqlserver/CHANGES.txt
    erp5/trunk/utils/erp5.recipe.mysqlserver/setup.py
    erp5/trunk/utils/erp5.recipe.mysqlserver/src/erp5/recipe/mysqlserver/__init__.py

Modified: erp5/trunk/utils/erp5.recipe.mysqlserver/CHANGES.txt
URL: http://svn.erp5.org/erp5/trunk/utils/erp5.recipe.mysqlserver/CHANGES.txt?rev=33975&r1=33974&r2=33975&view=diff
==============================================================================
--- erp5/trunk/utils/erp5.recipe.mysqlserver/CHANGES.txt [utf8] (original)
+++ erp5/trunk/utils/erp5.recipe.mysqlserver/CHANGES.txt [utf8] Tue Mar 23 01:06:04 2010
@@ -1,5 +1,11 @@
 Changelog
 =========
+
+1.0.2 (2010-03-22)
+------------------
+
+- Bug fix, fix the mysql_install_db run.
+  [Rafael Monnerat]
 
 1.0.1 (2010-03-22)
 ------------------

Modified: erp5/trunk/utils/erp5.recipe.mysqlserver/setup.py
URL: http://svn.erp5.org/erp5/trunk/utils/erp5.recipe.mysqlserver/setup.py?rev=33975&r1=33974&r2=33975&view=diff
==============================================================================
--- erp5/trunk/utils/erp5.recipe.mysqlserver/setup.py [utf8] (original)
+++ erp5/trunk/utils/erp5.recipe.mysqlserver/setup.py [utf8] Tue Mar 23 01:06:04 2010
@@ -1,7 +1,7 @@
 from setuptools import setup, find_packages
 
 name = "erp5.recipe.mysqlserver"
-version = '1.0.1'
+version = '1.0.2'
 
 def read(name):
     return open(name).read()

Modified: erp5/trunk/utils/erp5.recipe.mysqlserver/src/erp5/recipe/mysqlserver/__init__.py
URL: http://svn.erp5.org/erp5/trunk/utils/erp5.recipe.mysqlserver/src/erp5/recipe/mysqlserver/__init__.py?rev=33975&r1=33974&r2=33975&view=diff
==============================================================================
--- erp5/trunk/utils/erp5.recipe.mysqlserver/src/erp5/recipe/mysqlserver/__init__.py [utf8] (original)
+++ erp5/trunk/utils/erp5.recipe.mysqlserver/src/erp5/recipe/mysqlserver/__init__.py [utf8] Tue Mar 23 01:06:04 2010
@@ -38,14 +38,6 @@
     options.setdefault("mysql_auto_start", "false")
 
 
-  def _popen(self, command):
-    process = subprocess.Popen(command, 
-                               stdout=subprocess.PIPE, 
-                               stderr=subprocess.PIPE,
-                               shell=True, close_fds=True)
-    stdout, stderr = process.communicate()
-    return stdout, stderr
-
   def install_script(self, script_name):
     """ Create default scripts
     """
@@ -74,10 +66,9 @@
     ibdata1 = os.path.join(datadir, 'ibdata1')
     mysql_software_bin = options.get("mysql_software_bin")
     if not os.path.exists(ibdata1):
-      command = [ '%s/mysql_install_db' % (mysql_software_bin) , 
-                  '--datadir=%s' % (datadir)]
-
-      self._popen(command)
+      command = '%s/mysql_install_db --datadir=%s' % (mysql_software_bin, datadir)
+      print command
+      subprocess.call(command, shell=True)
 
     self.install_script('mysql')
     self.install_script("mysqld_safe")