[Erp5-report] r32837 jp - /erp5/trunk/products/ERP5Type/CodingStyle.py
nobody at svn.erp5.org
nobody at svn.erp5.org
Fri Feb 19 08:06:44 CET 2010
Author: jp
Date: Fri Feb 19 08:06:42 2010
New Revision: 32837
URL: http://svn.erp5.org?rev=32837&view=rev
Log:
Added one prefix (Form) and follow more closely checkConsistency API
Modified:
erp5/trunk/products/ERP5Type/CodingStyle.py
Modified: erp5/trunk/products/ERP5Type/CodingStyle.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/CodingStyle.py?rev=32837&r1=32836&r2=32837&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/CodingStyle.py [utf8] (original)
+++ erp5/trunk/products/ERP5Type/CodingStyle.py [utf8] Fri Feb 19 08:06:42 2010
@@ -79,18 +79,20 @@
'NotificationTool',
'ERP5Site',
'ERP5Type',
+ 'Form', # Acceptable for ERP5 Forms which will soon become portal types too
))
skin_prefix_list = set(skin_prefix_list)
return skin_prefix_list
# Generic method to check consistency of a skin item
-def checkConsistency(self, source_code=None):
+def checkConsistency(self, fixit=0, source_code=None):
"""
Make sure skin folder item has appropriate prefix
and that its source code, if any, does not contain
calls to legacy methods
"""
+ if fixit: raise NotImplementedError
message_list = []
portal_path = self.getPortalObject().getPath()
portal_path_len = len(portal_path)
@@ -116,16 +118,16 @@
return message_list
# Add checkConsistency to Python Scripts
-def checkPythonScriptConsistency(self):
- return checkConsistency(self, source_code=self.body())
+def checkPythonScriptConsistency(self, fixit=0):
+ return checkConsistency(self, fixit=fixit, source_code=self.body())
from Products.PythonScripts.PythonScript import PythonScript
PythonScript.checkConsistency= checkPythonScriptConsistency
PythonScript.checkConsistency__roles__ = ('Manager',) # A hack to protect the method
# Add checkConsistency to Page Templates
-def checkPageTemplateConsistency(self):
- return checkConsistency(self, source_code=self.read())
+def checkPageTemplateConsistency(self, fixit=0):
+ return checkConsistency(self, fixit=fixit, source_code=self.read())
from Products.PageTemplates.PageTemplate import PageTemplate
PageTemplate.checkConsistency= checkPageTemplateConsistency
More information about the Erp5-report
mailing list