[Erp5-report] r30013 - /erp5/trunk/utils/erp5diff/ERP5Diff.py

nobody at svn.erp5.org nobody at svn.erp5.org
Mon Oct 26 18:23:32 CET 2009


Author: nicolas
Date: Mon Oct 26 18:23:29 2009
New Revision: 30013

URL: http://svn.erp5.org?rev=30013&view=rev
Log:
Use boolean instead of integer

Modified:
    erp5/trunk/utils/erp5diff/ERP5Diff.py

Modified: erp5/trunk/utils/erp5diff/ERP5Diff.py
URL: http://svn.erp5.org/erp5/trunk/utils/erp5diff/ERP5Diff.py?rev=30013&r1=30012&r2=30013&view=diff
==============================================================================
--- erp5/trunk/utils/erp5diff/ERP5Diff.py [utf8] (original)
+++ erp5/trunk/utils/erp5diff/ERP5Diff.py [utf8] Mon Oct 26 18:23:29 2009
@@ -108,9 +108,7 @@
     """
       Check whether the element has any children
     """
-    if len(element) == 0:
-      return False
-    return True
+    return bool(len(element))
 
   def _xupdateAppendAttributes(self, dict, path):
     """
@@ -233,10 +231,10 @@
     """
     # Make sure that they are elements.
     if type(element1) !=  type(element2) or type(element1) != etree._Element:
-      return 0
+      return False
 
     if element1.tag != element2.tag:
-      return 0
+      return False
 
     id_list = []
     for attr_map in (element1.attrib, element2.attrib):
@@ -246,9 +244,9 @@
           break
 
     if len(id_list) == 0:
-      return 1
+      return True
     if len(id_list) == 1:
-      return 0
+      return False
     return (id_list[0] == id_list[1])
 
   def _testAttributes(self, element1, element2, path):
@@ -289,10 +287,10 @@
     """
     for child in element:
       if type(child) == etree._Element:
-        return 0
+        return False
     if element.text is not None:
-      return 0
-    return 1
+      return False
+    return True
 
   def _checkIgnoreText(self, element):
     """
@@ -301,8 +299,8 @@
     """
     for child in element:
       if type(child) == etree._Element:
-        return 1
-    return 0
+        return True
+    return False
 
   def _makeRelativePathList(self, element_list):
     """




More information about the Erp5-report mailing list