[Erp5-report] r27902 - /erp5/trunk/products/ERP5/Document/

[nobody at svn.erp5.org]

Author: luke
Date: Fri Jul  3 13:09:57 2009
New Revision: 27902

URL: http://svn.erp5.org?rev=27902&view=rev
Log:
 - remove docstrings from methods, which are documented in related interfaces to avoid duplication and desynchronisation of documentation
 - remove empty and bogus docstrings

Modified:
    erp5/trunk/products/ERP5/Document/BusinessPath.py
    erp5/trunk/products/ERP5/Document/BusinessProcess.py

Modified: erp5/trunk/products/ERP5/Document/BusinessPath.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/BusinessPath.py?rev=27902&r1=27901&r2=27902&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/BusinessPath.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/BusinessPath.py [utf8] Fri Jul  3 13:09:57 2009
@@ -176,8 +176,6 @@
 
   # IBusinessBuildable implementation
   def isBuildable(self, explanation):
-    """
-    """
     if self.isCompleted(explanation):
       return False # No need to build what was already built
     if self.isFrozen(explanation):
@@ -195,9 +193,6 @@
     """
 
   def build(self, explanation):
-    """
-      Build
-    """
     builder_list = self.getBuilderList() # Missing method
     for builder in builder_list:
       builder.build(causality_uid=self.getUid()) # This is one way of doing
@@ -213,10 +208,6 @@
 
   # IBusinessCompletable implementation
   def isCompleted(self, explanation):
-    """
-      Looks at all simulation related movements
-      and checks the simulation_state of the delivery
-    """
     acceptable_state_list = self.getCompletedStateList()
     for movement in self._getRelatedSimulationMovementList(explanation):
       if movement.getSimulationState() not in acceptable_state_list:
@@ -224,10 +215,6 @@
     return True
 
   def isPartiallyCompleted(self, explanation):
-    """
-      Looks at all simulation related movements
-      and checks the simulation_state of the delivery
-    """
     acceptable_state_list = self.getCompletedStateList()
     for movement in self._getRelatedSimulationMovementList(explanation):
       if movement.getSimulationState() in acceptable_state_list:
@@ -235,10 +222,6 @@
     return False
 
   def isFrozen(self, explanation):
-    """
-      Looks at all simulation related movements
-      and checks if frozen
-    """
     movement_list = self._getRelatedSimulationMovementList(explanation)
     if len(movement_list) == 0:
       return False # Nothing to be considered as Frozen
@@ -287,13 +270,6 @@
         return expected_date - self.getLeadTime()
 
   def getExpectedStopDate(self, explanation, predecessor_date=None, *args, **kwargs):
-    """
-      Returns the expected stop date for this
-      path based on the explanation.
-
-      predecessor_date -- if provided, computes the date base on the
-                          date value provided
-    """
     return self._getExpectedDate(explanation,
                                  self._getRootExplanationExpectedStopDate,
                                  self._getPredecessorExpectedStopDate,

Modified: erp5/trunk/products/ERP5/Document/BusinessProcess.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/BusinessProcess.py?rev=27902&r1=27901&r2=27902&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/BusinessProcess.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/BusinessProcess.py [utf8] Fri Jul  3 13:09:57 2009
@@ -142,9 +142,6 @@
     return filter(lambda x:x.isPartiallyCompleted(explanation), self.getStateValueList())
 
   def getLatestCompletedStateValue(self, explanation):
-    """
-      Returns the most advanced completed state
-    """
     for state in self.getCompletedStateValueList(explanation):
       for path in state.getPredecessorRelatedValueList():
         if not path.isCompleted(explanation):
@@ -152,9 +149,6 @@
     return None
 
   def getLatestPartiallyCompletedStateValue(self, explanation):
-    """
-      Returns the most advanced completed state
-    """
     for state in self.getCompletedStateValueList(explanation):
       for path in state.getPredecessorRelatedValueList():
         if not path.isPartiallyCompleted(explanation):
@@ -162,9 +156,6 @@
     return None
 
   def getLatestCompletedStateValueList(self, explanation):
-    """
-      Returns the most advanced completed state
-    """
     result = []
     for state in self.getCompletedStateValueList(explanation):
       for path in state.getPredecessorRelatedValueList():
@@ -173,9 +164,6 @@
     return result
 
   def getLatestPartiallyCompletedStateValueList(self, explanation):
-    """
-      Returns the most advanced completed state
-    """
     result = []
     for state in self.getCompletedStateValueList(explanation):
       for path in state.getPredecessorRelatedValueList():
@@ -197,9 +185,6 @@
     return self.getReferentialDate() == 'stop_date'
 
   def getTradePhaseList(self):
-    """
-      Returns all trade_phase of this business process
-    """
     path_list = self.objectValues(portal_type=self.getPortalBusinessPathTypeList())
     return filter(None, [path.getTradePhase()
                          for path in path_list])