[Erp5-report] r27891 - /erp5/trunk/products/ERP5/interfaces/

[nobody at svn.erp5.org]

Author: luke
Date: Fri Jul  3 10:41:32 2009
New Revision: 27891

URL: http://svn.erp5.org?rev=27891&view=rev
Log:
 - move isFrozen to business_completable
 - make isFrozen definition clear for simulation_movement and business_completable

Modified:
    erp5/trunk/products/ERP5/interfaces/business_buildable.py
    erp5/trunk/products/ERP5/interfaces/business_completable.py
    erp5/trunk/products/ERP5/interfaces/simulation_movement.py

Modified: erp5/trunk/products/ERP5/interfaces/business_buildable.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/interfaces/business_buildable.py?rev=27891&r1=27890&r2=27891&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/interfaces/business_buildable.py [utf8] (original)
+++ erp5/trunk/products/ERP5/interfaces/business_buildable.py [utf8] Fri Jul  3 10:41:32 2009
@@ -30,12 +30,7 @@
 from zope.interface import Interface
 
 class IBusinessBuildable(Interface):
-  """Business Buildable interface specification
-
-  TODO:
-    - is isFrozen useful ? is it the same as isCompleted ?
-    - why isFrozen is here and not in Completable
-  """
+  """Business Buildable interface specification"""
   def isBuildable(explanation):
     """Returns True if any of the related Simulation Movement
     is buildable and if the predecessor state is completed.
@@ -52,17 +47,6 @@
     cause of a root applied rule in the simulation
     """
 
-  def isFrozen(explanation):
-    """Returns True if all related movements in the simulation
-    are frozen
-
-    'explanation' is the Order or Item or Document which is the
-    cause of a root applied rule in the simulation
-
-    XXX - could be redundant with isBuildable
-    (isFrozen = not isBuildable ?)
-    """
-
   def build(explanation):
     """Builds all related movements in the simulation
     using the builders of Business Path

Modified: erp5/trunk/products/ERP5/interfaces/business_completable.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/interfaces/business_completable.py?rev=27891&r1=27890&r2=27891&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/interfaces/business_completable.py [utf8] (original)
+++ erp5/trunk/products/ERP5/interfaces/business_completable.py [utf8] Fri Jul  3 10:41:32 2009
@@ -45,6 +45,11 @@
     as finished.
     """
 
+  def isFrozen(explanation):
+    """True if all related simulation movements for this explanation
+    are frozen.
+    """
+
   def getExpectedCompletionDate(task):
     """Returns the date at which the given state is expected to
     be completed, based on the start_date and stop_date of

Modified: erp5/trunk/products/ERP5/interfaces/simulation_movement.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/interfaces/simulation_movement.py?rev=27891&r1=27890&r2=27891&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/interfaces/simulation_movement.py [utf8] (original)
+++ erp5/trunk/products/ERP5/interfaces/simulation_movement.py [utf8] Fri Jul  3 10:41:32 2009
@@ -103,11 +103,10 @@
   def isFrozen():
     """Tells whether the simulation movement is frozen.
     By default, looks up the related Business Process Path
-    and tells if the simulation state is part of completed
+    and tells if the simulation state is part of frozen
     states.
 
-    XXX - should this be renamed isCompleted ? are the
-    notions of isFrozen and isCompleted same or different ?
+    Frozen simulation movement cannot be modified by expanding.
     """
 
   def isSimulated():