[Erp5-report] r27599 - /erp5/trunk/products/ERP5Form/SelectionTool.py

[nobody at svn.erp5.org]

Author: kazuhiko
Date: Tue Jun 16 13:36:08 2009
New Revision: 27599

URL: http://svn.erp5.org?rev=27599&view=rev
Log:
calling getStorageItemList() in getStorage() is bad for performance.

Modified:
    erp5/trunk/products/ERP5Form/SelectionTool.py

Modified: erp5/trunk/products/ERP5Form/SelectionTool.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Form/SelectionTool.py?rev=27599&r1=27598&r2=27599&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Form/SelectionTool.py [utf8] (original)
+++ erp5/trunk/products/ERP5Form/SelectionTool.py [utf8] Tue Jun 16 13:36:08 2009
@@ -139,13 +139,11 @@
         RESPONSE.redirect('%s/manage_configure' % (self.absolute_url()))
 
     security.declareProtected( ERP5Permissions.ManagePortal, 'getStorage')
-    def getStorage(self, default=None):
+    def getStorage(self, default='selection_data'):
       """return the selected storage
       """
-      if default is None:
-        default = self.getStorageItemList()[0][1]
       storage = getattr(aq_base(self), 'storage', default)
-      if storage is not default and storage not in [item[1] for item in self.getStorageItemList()]:
+      if storage is not default:
         #Backward compatibility
         if storage == 'Persistent Mapping':
           storage = 'selection_data'