[Erp5-report] r26528 - /erp5/trunk/products/ZSQLCatalog/SQLCatalog.py

[nobody at svn.erp5.org]

Author: vincent
Date: Mon Apr 20 17:58:08 2009
New Revision: 26528

URL: http://svn.erp5.org?rev=26528&view=rev
Log:
Warn about related keys named after real columns and duplicate related keys only once per zope run.

Modified:
    erp5/trunk/products/ZSQLCatalog/SQLCatalog.py

Modified: erp5/trunk/products/ZSQLCatalog/SQLCatalog.py
URL: http://svn.erp5.org/erp5/trunk/products/ZSQLCatalog/SQLCatalog.py?rev=26528&r1=26527&r2=26528&view=diff
==============================================================================
--- erp5/trunk/products/ZSQLCatalog/SQLCatalog.py [utf8] (original)
+++ erp5/trunk/products/ZSQLCatalog/SQLCatalog.py [utf8] Mon Apr 20 17:58:08 2009
@@ -225,6 +225,7 @@
     self.temporary_buffer.setdefault(tid, []).extend(iterable)
 
 related_key_definition_cache = {}
+related_key_warned_column_set = set()
 
 class Catalog(Folder,
               Persistent,
@@ -1740,7 +1741,9 @@
         LOG('SQLCatalog', WARNING, 'Malformed related key definition: %r. Ignored.' % (related_key, ))
         continue
       related_key_id = split_entire_definition[0].strip()
-      if related_key_id in column_set:
+      if related_key_id in column_set and \
+         related_key_id not in related_key_warned_column_set:
+        related_key_warned_column_set.add(related_key_id)
         if related_key_id in column_map:
           LOG('SQLCatalog', WARNING, 'Related key %r has the same name as an existing column on tables %r' % (related_key_id, column_map[related_key_id]))
         else: