[Erp5-report] r24566 - in /erp5/trunk/products/ERP5Form: ./ tests/

nobody at svn.erp5.org nobody at svn.erp5.org
Wed Nov 12 18:59:41 CET 2008


Author: jerome
Date: Wed Nov 12 18:59:40 2008
New Revision: 24566

URL: http://svn.erp5.org?rev=24566&view=rev
Log:
float field was not rounding values when precision = 0

Modified:
    erp5/trunk/products/ERP5Form/FormulatorPatch.py
    erp5/trunk/products/ERP5Form/tests/testFields.py

Modified: erp5/trunk/products/ERP5Form/FormulatorPatch.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Form/FormulatorPatch.py?rev=24566&r1=24565&r2=24566&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Form/FormulatorPatch.py [utf8] (original)
+++ erp5/trunk/products/ERP5Form/FormulatorPatch.py [utf8] Wed Nov 12 18:59:40 2008
@@ -1325,7 +1325,7 @@
               return value
           try :
             float_value = float(value)
-            if precision:
+            if precision not in (None, ''):
               float_value = round(float_value, precision)
             value = str(float_value)
           except ValueError:

Modified: erp5/trunk/products/ERP5Form/tests/testFields.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Form/tests/testFields.py?rev=24566&r1=24565&r2=24566&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Form/tests/testFields.py [utf8] (original)
+++ erp5/trunk/products/ERP5Form/tests/testFields.py [utf8] Wed Nov 12 18:59:40 2008
@@ -105,6 +105,8 @@
   def test_format_precision(self):
     self.field.values['precision'] = 0
     self.assertEquals('12', self.widget.format_value(self.field, 12.34))
+    # value is rounded
+    self.assertEquals('13', self.widget.format_value(self.field, 12.9))
 
     purgeFieldValueCache() # call this before changing internal field values.
     self.field.values['precision'] = 2




More information about the Erp5-report mailing list