[Erp5-report] r18544 - /erp5/trunk/products/ERP5Type/XMLMatrix.py

[nobody at svn.erp5.org]

Author: vincent
Date: Fri Dec 28 15:22:31 2007
New Revision: 18544

URL: http://svn.erp5.org?rev=18544&view=rev
Log:
Avoid creating a PersistentMapping instance to just overwrite it at function end.

Modified:
    erp5/trunk/products/ERP5Type/XMLMatrix.py

Modified: erp5/trunk/products/ERP5Type/XMLMatrix.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/XMLMatrix.py?rev=18544&r1=18543&r2=18544&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/XMLMatrix.py (original)
+++ erp5/trunk/products/ERP5Type/XMLMatrix.py Fri Dec 28 15:22:31 2007
@@ -191,12 +191,6 @@
       if current_range == list(kw): # kw is a tuple
         return
 
-      # We must make sure the base_id exists
-      # in the event of a matrix creation for example
-      if not self.index.has_key(base_id):
-        # Create an index for this base_id
-        self.index[base_id] = PersistentMapping()
-
       # Recreate a new index for the new range defined in *kw
       i = 0
       for index_ids in kw:
@@ -207,18 +201,19 @@
           j += 1
         i += 1
 
-      # Look at each dimension i of the previous index
-      for i in self.index[base_id].keys():
-        movement[i] = {}
-        # If the new index has the same dimensionality
-        # Look at new location of cells
-        if new_index.has_key(i):
-          # Look at each index in a given dimension i
-          for my_id in self.index[base_id][i].keys():
-            new_place = new_index[i].get(my_id)
-            old_place = self.index[base_id][i][my_id]
-            # create a movement in dimension i between old_place and new_place
-            movement[i][old_place] = new_place
+      if self.index.has_key(base_id):
+        # Look at each dimension i of the previous index
+        for i in self.index[base_id].keys():
+          movement[i] = {}
+          # If the new index has the same dimensionality
+          # Look at new location of cells
+          if new_index.has_key(i):
+            # Look at each index in a given dimension i
+            for my_id in self.index[base_id][i].keys():
+              new_place = new_index[i].get(my_id)
+              old_place = self.index[base_id][i][my_id]
+              # create a movement in dimension i between old_place and new_place
+              movement[i][old_place] = new_place
 
       # Rename every 'object_id' by 'temp_object_id'
       object_id_list = []