[Erp5-report] r16771 - /erp5/trunk/products/ERP5Form/Form.py

nobody at svn.erp5.org nobody at svn.erp5.org
Tue Oct 2 11:44:24 CEST 2007


Author: jerome
Date: Tue Oct  2 11:44:24 2007
New Revision: 16771

URL: http://svn.erp5.org?rev=16771&view=rev
Log:
use isinstance to check types

Modified:
    erp5/trunk/products/ERP5Form/Form.py

Modified: erp5/trunk/products/ERP5Form/Form.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Form/Form.py?rev=16771&r1=16770&r2=16771&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Form/Form.py (original)
+++ erp5/trunk/products/ERP5Form/Form.py Tue Oct  2 11:44:24 2007
@@ -66,7 +66,7 @@
     value as is)
   """
   def __init__(self, value):
-    if type(aq_base(value)) is  Method:
+    if isinstance(aq_base(value), Method):
       value = Method(value.method_name)
     self.value = value
 
@@ -151,7 +151,7 @@
 
 class OverrideValue(StaticValue):
   def __init__(self, override):
-    if type(aq_base(override)) is  Method:
+    if isinstance(aq_base(override), Method):
       override = Method(override.method_name)
     self.override = override
 
@@ -161,7 +161,7 @@
 class DefaultValue(StaticValue):
   def __init__(self, field_id, value):
     self.key = field_id[3:]
-    if type(aq_base(value)) is  Method:
+    if isinstance(aq_base(value), Method):
       value = Method(value.method_name)
     self.value = value
 
@@ -771,9 +771,9 @@
             for key, value in _dict.items():
                 if value=='':
                     continue
-                if type(value) is Method:
+                if isinstance((value, Method):
                     value = Method(value.method_name)
-                elif type(value) is TALESMethod:
+                elif isinstance(value, TALESMethod):
                     value = TALESMethod(value._text)
                 elif value is not None and not isinstance(value,
                         (str, unicode, int, long, bool, list, tuple, dict)):




More information about the Erp5-report mailing list