[Erp5-report] r10793 - /erp5/trunk/products/ERP5Type/Accessor/

nobody at svn.erp5.org nobody at svn.erp5.org
Wed Oct 18 09:22:11 CEST 2006


Author: jerome
Date: Wed Oct 18 09:22:06 2006
New Revision: 10793

URL: http://svn.erp5.org?rev=10793&view=rev
Log:
Content Setters should use _getOb when checking if subcontent exists, not
getattr, because we do not want to modify an acquired object.


Modified:
    erp5/trunk/products/ERP5Type/Accessor/AcquiredProperty.py
    erp5/trunk/products/ERP5Type/Accessor/ContentProperty.py

Modified: erp5/trunk/products/ERP5Type/Accessor/AcquiredProperty.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/Accessor/AcquiredProperty.py?rev=10793&r1=10792&r2=10793&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/Accessor/AcquiredProperty.py (original)
+++ erp5/trunk/products/ERP5Type/Accessor/AcquiredProperty.py Wed Oct 18 09:22:06 2006
@@ -154,7 +154,7 @@
     def __call__(self, instance, value, *args, **kw):
       from Products.ERP5Type.Utils import assertAttributePortalType
       assertAttributePortalType(instance, self._storage_id, self._portal_type)
-      o = getattr(instance, self._storage_id, None)
+      o = instance._getOb(self._storage_id, None)
       if o is None:
         o = instance.newContent(id = self._storage_id, portal_type = self._portal_type[0])
       if self._reindex:

Modified: erp5/trunk/products/ERP5Type/Accessor/ContentProperty.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/Accessor/ContentProperty.py?rev=10793&r1=10792&r2=10793&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/Accessor/ContentProperty.py (original)
+++ erp5/trunk/products/ERP5Type/Accessor/ContentProperty.py Wed Oct 18 09:22:06 2006
@@ -208,7 +208,7 @@
       o = None
       available_id = None
       for k in self._storage_id_list:
-        o = getattr(instance, k, None)
+        o = instance._getOb(k, None)
         if o is None: available_id = k
         if o is not None and o.portal_type in self._portal_type:
           if self._reindex:




More information about the Erp5-report mailing list