[Erp5-report] r9939 - /erp5/trunk/products/ERP5OOo/Document/DMSFile.py

[nobody at svn.erp5.org]

Author: bartek
Date: Thu Sep 14 20:56:26 2006
New Revision: 9939

URL: http://svn.erp5.org?rev=9939&view=rev
Log:
removed caching of wiki methods - it was very bad

Modified:
    erp5/trunk/products/ERP5OOo/Document/DMSFile.py

Modified: erp5/trunk/products/ERP5OOo/Document/DMSFile.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5OOo/Document/DMSFile.py?rev=9939&r1=9938&r2=9939&view=diff
==============================================================================
--- erp5/trunk/products/ERP5OOo/Document/DMSFile.py (original)
+++ erp5/trunk/products/ERP5OOo/Document/DMSFile.py Thu Sep 14 20:56:26 2006
@@ -232,16 +232,22 @@
     getWikiSuccessorValueList - the way to find objects is on 
     implementation level
     '''
-    def cached_getWikiSuccessorValueList():
-      lst=[]
-      for ref in self.getWikiSuccessorReferenceList():
-        res=self.DMS_findDocument(ref)
-        if len(res)>0:
-          lst.append(res[0].getObject())
-      return lst
-    cached_getWikiSuccessorValueList = CachingMethod(cached_getWikiSuccessorValueList,
-        id='DMSFile_getWikiSuccessorValueList')
-    return cached_getWikiSuccessorValueList()
+    lst=[]
+    for ref in self.getWikiSuccessorReferenceList():
+      res=self.DMS_findDocument(ref)
+      if len(res)>0:
+        lst.append(res[0].getObject())
+    return lst
+    #def cached_getWikiSuccessorValueList():
+      #lst=[]
+      #for ref in self.getWikiSuccessorReferenceList():
+        #res=self.DMS_findDocument(ref)
+        #if len(res)>0:
+          #lst.append(res[0].getObject())
+      #return lst
+    #cached_getWikiSuccessorValueList = CachingMethod(cached_getWikiSuccessorValueList,
+        #id='DMSFile_getWikiSuccessorValueList')
+    #return cached_getWikiSuccessorValueList()
 
   security.declareProtected(Permissions.View, 'getWikiPredecessorValueList')
   def getWikiPredecessorValueList(self):
@@ -250,21 +256,26 @@
     document, and on how a doc must reference me to be my predecessor (reference only,
     or with a language, etc
     '''
-    def cached_getWikiPredecessorValueList():
-      lst=self.DMS_findPredecessors()
-      lst=[r.getObject() for r in lst]
-      di=dict.fromkeys(lst) # make it unique
-      ref=self.getReference()
-      return [o for o in di.keys() if o.getReference()!=ref] # every object has its own reference in SearchableText
-    cached_getWikiPredecessorValueList=CachingMethod(cached_getWikiPredecessorValueList,
-        id='DMSFile_getWikiPredecessorValueList')
-    return cached_getWikiPredecessorValueList()
+    lst=self.DMS_findPredecessors()
+    lst=[r.getObject() for r in lst]
+    di=dict.fromkeys(lst) # make it unique
+    ref=self.getReference()
+    return [o for o in di.keys() if o.getReference()!=ref] # every object has its own reference in SearchableText
+    #def cached_getWikiPredecessorValueList():
+      #lst=self.DMS_findPredecessors()
+      #lst=[r.getObject() for r in lst]
+      #di=dict.fromkeys(lst) # make it unique
+      #ref=self.getReference()
+      #return [o for o in di.keys() if o.getReference()!=ref] # every object has its own reference in SearchableText
+    #cached_getWikiPredecessorValueList=CachingMethod(cached_getWikiPredecessorValueList,
+        #id='DMSFile_getWikiPredecessorValueList')
+    #return cached_getWikiPredecessorValueList()
 
   security.declareProtected(Permissions.View,'getContributorList')
   def getContributorList(self):
-    #'''
-    #override
-    #'''
+    '''
+    override
+    '''
     return (self.getContributorRelatedTitleList() or [])+(self.getContributorNameList() or [])
   
   getContributorsList=getContributorList