[Erp5-dev] [PATCH] ListBox filtered notification todo support domain selection write tests

[bk at raskon.org]

We think this answer is done by person who did not answer to users' calls.
:) 

On 21/12/11 11:31, jp at nexedi.com wrote:
> Hi,
> 
> > Later we will write functional tests. We didn't expect that you commit
> > the patch, we just sent it because think it is high importance
> > functionality.
> 
> This feature (in this way or another way) is very useful. Thank you.
> 
> We are still wondering what is the best message to display. Also, whenever listbox is set to display an empty list (if not filtered), which is one option in listbox, then displaying a "filetered" message is useless. So this means that the "filtered" message does not need to be displayed in some cases since it is redundant.
> 
> Some users would also like to see which "hidden" parameters are used to filter a list. This could be achieved by rendering selection Query objects in a pretty form, something which is in theory possible thanks to the grammar which was defined for catalog query parameters. But I think it is still not implemented.
> 
> Overall, I would implement the feature you are proposing:
> 1- by extending Listbox API (so that this feature is explicit for all types of listbox of renderer, for example through a parameter which is passed or through a method) and not only one Listbox renderer
> 2- by taking into account possible conflict with the feature of displaying nothing without explicit filtering in Listbox API
> 3- by taking into account the problem of rendering selection query parameters (in listbox header or elsewhere) as Query objects are supposed to be able to do through the grammar which they define
> 4- by covering the feature with a functional test
> 
> Regards,
> 
> JPS.
> 
> 
> > 
> > Vera
> > 
> > В Вт., 20/12/2011 в 14:27 +0100, Kazuhiko Shiozaki пишет:
> > > Hi Boris,
> > > 
> > > On 19/12/2011 19:19, Boris Kocherov wrote:
> > > > ---
> > > >  .../erp5_xhtml_style/ListBox_asHTML.xml            |    1 +
> > > >  .../erp5_xhtml_style/ListBox_asHTMLLibrary.xml     |   14 +++++++-
> > > >  .../erp5_xhtml_style/erp5_listbox.css.xml          |    6 +++
> > > >  product/ERP5Form/ListBox.py                        |   34 +++++++++++++++----
> > > >  product/ERP5Form/Selection.py                      |    2 +-
> > > >  5 files changed, 47 insertions(+), 10 deletions(-)
> > > 
> > > Thanks for your patch.
> > > 
> > > Before merging, could you provide us more detail about this patch, like
> > > the purpose of this patch, which problem will be solved by this patch
> > > etc. please ?
> > > 
> > > And also functional tests to test the new feature are required,
> > > especially for listbox rendering changes like this patch.
> > > 
> > > Thanks in advance.
> > > 
> > > Best regards,
> > 
> > 

> _______________________________________________
> Erp5-dev mailing list
> Erp5-dev at erp5.org
> https://mail.tiolive.com/mailman/listinfo/erp5-dev