[Erp5-dev] [Erp5-report] ERP5 r24898: 2308 Tests, 1 Errors, 12 Failures

[Vincent Pelletier]

Le Tuesday 16 December 2008 09:05:36 Robin Sébastien, vous avez écrit :
> > Hi,
> >
> > can someone take a look in the followed tests (and fix if it's possible)?
> >
> > >   testSQLCachedWorklist                              (1 failures)
> > >    test_02_related_key (testSQLCachedWorklist.TestSQLCachedWorklist)
>
> This comes from a new feature and test added by Julien : support of related
> keys in worklist, this was added for testWorklist, and by inheritance it is
> also tested in testSQLCachedWorklist. Unfortunately, this is currently
> working only for usual worklist, and it not implemented yet with
> optimisation on worklists tested by testSQLCachedWorklist.
>
> So there is no regression, but more work will be required in the future to
> make sure to make it also working with cached worklist.

One additional note: it should *not* be implemented without spending some time 
to rething how columns are handled in cached worklists.
Currently, they are hardcoded in 2 places (a "create table" zsql method, and 
the product). To implement related key support, we would have to extend 
existing table column list with the list of all related keys (including 
generated ones) to make it "work" in a generic instance.
What should be done is making those column lists computed so that table schema 
changes dynamicaly to match worklist needs (or at the very least, provide a 
central script for user to specify the list of column he needs).

-- 
Vincent Pelletier