[Erp5-dev] packing list container state and container cloneing and deletion

[Łukasz Nowak]

On Fri, 2008-10-31 at 13:06 +0100, Robin Sébastien wrote:
> Hi,
> 
> > Hello,
> >
> > I've created tests for cases in sale packing lists, when containers are
> > cloned or deleted. Patch attached.
> >
> > I updated sequence with new container line in
> > stepSetContainerFullQuantity, as it is needed for me in more sequences.
> 
> Can you please explain what fails currently ? Does it fails because 
> packing_list_container_worklow is not updated when we clone container or lines 
> ?

Yes - its exactly issues with operation on Container, Container Line and
shall be with Sale Packing List Line/Cell portal types (last are not
covered yet).

> > What is your opinion? Shall I commit this? (Tests fails for now.)
> 
> You have to take care that the TestPurchasePackingList is included in 
> testPackingList, and all tests inside testPackingList are also executed for 
> testPurchasePackingList.
> 
> May be you already noticed it, but if you execute testPackingList unit test 
> with --run_only=test_08a_AddContainersCloneContainer , you will that this test 
> method will be executed 2 times, one time for TestPackingList, and another 
> time for TestPurchasePackingList.
> 
> For the initial test_08 for containers, there is some kind of hack in the 
> class TestPurchasePackingListMixin. So having more tests related to containers 
> is a very nice idea, but it would be nice to move all tests related to 
> containers in a separated class, either inside testPackingList.py or on 
> another py file.

Indeed - I've observed such behaviour. So I'll have to wait for
maintainer of this part to create such test and than do any activity in
this field?

Regards,
Luke

-- 
Łukasz Nowak R&D Ventis http://www.ventis.com.pl/
tel: +48 32 768 16 85 fax: +48 32 392 10 61
``Use the Source, Luke...'' I am only craftsman.