[Neo-report] r2293 vincent - /trunk/neo/storage/replicator.py

nobody at svn.erp5.org nobody at svn.erp5.org
Sun Sep 5 11:14:55 CEST 2010


Author: vincent
Date: Sun Sep  5 11:14:55 2010
New Revision: 2293

Log:
Use pop() instead of __getitem__() & __delitem__().

Modified:
    trunk/neo/storage/replicator.py

Modified: trunk/neo/storage/replicator.py
==============================================================================
--- trunk/neo/storage/replicator.py [iso-8859-1] (original)
+++ trunk/neo/storage/replicator.py [iso-8859-1] Sun Sep  5 11:14:55 2010
@@ -151,12 +151,11 @@ class Replicator(object):
     def setCriticalTID(self, uuid, tid):
         """This is a callback from MasterOperationHandler."""
         try:
-            partition_list = self.critical_tid_dict[uuid]
+            partition_list = self.critical_tid_dict.pop(uuid)
             logging.debug('setting critical TID %s to %s', dump(tid),
                          ', '.join([str(p.getRID()) for p in partition_list]))
-            for partition in self.critical_tid_dict[uuid]:
+            for partition in partition_list:
                 partition.setCriticalTID(tid)
-            del self.critical_tid_dict[uuid]
         except KeyError:
             logging.debug("setCriticalTID raised KeyError for %s" %
                     (dump(uuid), ))





More information about the Neo-report mailing list