[Neo-report] r2182 gregory - in /trunk/neo: client/ client/handlers/ tests/client/

[nobody at svn.erp5.org]

Author: gregory
Date: Mon Jun 21 17:54:35 2010
New Revision: 2182

Log:
Use pop(0) instead of reverse + pop() on a list.

Modified:
    trunk/neo/client/app.py
    trunk/neo/client/handlers/master.py
    trunk/neo/tests/client/testMasterHandler.py

Modified: trunk/neo/client/app.py
==============================================================================
--- trunk/neo/client/app.py [iso-8859-1] (original)
+++ trunk/neo/client/app.py [iso-8859-1] Mon Jun 21 17:54:35 2010
@@ -410,7 +410,7 @@ class Application(object):
                 self._askPrimary(Packets.AskNewOIDs(100))
                 if len(self.new_oid_list) <= 0:
                     raise NEOStorageError('new_oid failed')
-            self.last_oid = self.new_oid_list.pop()
+            self.last_oid = self.new_oid_list.pop(0)
             return self.last_oid
         finally:
             self._oid_lock_release()

Modified: trunk/neo/client/handlers/master.py
==============================================================================
--- trunk/neo/client/handlers/master.py [iso-8859-1] (original)
+++ trunk/neo/client/handlers/master.py [iso-8859-1] Mon Jun 21 17:54:35 2010
@@ -163,7 +163,6 @@ class PrimaryAnswersHandler(AnswerBaseHa
 
     def answerNewOIDs(self, conn, oid_list):
         self.app.new_oid_list = oid_list
-        self.app.new_oid_list.reverse()
 
     def answerTransactionFinished(self, conn, tid):
         if tid != self.app.getTID():

Modified: trunk/neo/tests/client/testMasterHandler.py
==============================================================================
--- trunk/neo/tests/client/testMasterHandler.py [iso-8859-1] (original)
+++ trunk/neo/tests/client/testMasterHandler.py [iso-8859-1] Mon Jun 21 17:54:35 2010
@@ -238,7 +238,7 @@ class MasterAnswersHandlerTests(MasterHa
         conn = self.getConnection()
         oid1, oid2, oid3 = self.getOID(0), self.getOID(1), self.getOID(2)
         self.handler.answerNewOIDs(conn, [oid1, oid2, oid3])
-        self.assertEqual(self.app.new_oid_list, [oid3, oid2, oid1])
+        self.assertEqual(self.app.new_oid_list, [oid1, oid2, oid3])
 
     def test_answerTransactionFinished(self):
         conn = self.getConnection()