[Neo-report] r1798 gregory - in /trunk/neo/client: Storage.py app.py

[nobody at svn.erp5.org]

Author: gregory
Date: Fri Feb 19 09:46:34 2010
New Revision: 1798

Log:
Fix history prototype.

- Rename length 'parameter' to 'size'
- Define None as default version.

See HistoryTests.checkSimpleHistory.

Modified:
    trunk/neo/client/Storage.py
    trunk/neo/client/app.py

Modified: trunk/neo/client/Storage.py
==============================================================================
--- trunk/neo/client/Storage.py [iso-8859-1] (original)
+++ trunk/neo/client/Storage.py [iso-8859-1] Fri Feb 19 09:46:34 2010
@@ -123,8 +123,8 @@
     def registerDB(self, db, limit):
         self.app.registerDB(db, limit)
 
-    def history(self, oid, version, length=1, filter=None):
-        return self.app.history(oid, version, length, filter)
+    def history(self, oid, version=None, size=1, filter=None):
+        return self.app.history(oid, version, size, filter)
 
     def sync(self):
         self.app.sync()

Modified: trunk/neo/client/app.py
==============================================================================
--- trunk/neo/client/app.py [iso-8859-1] (original)
+++ trunk/neo/client/app.py [iso-8859-1] Fri Feb 19 09:46:34 2010
@@ -400,7 +400,7 @@
         finally:
             self._cache_lock_release()
         # history return serial, so use it
-        hist = self.history(oid, length = 1, object_only = 1)
+        hist = self.history(oid, size=1, object_only=1)
         if len(hist) == 0:
             raise NEOStorageNotFoundError()
         if hist[0] != oid:
@@ -878,7 +878,7 @@
     def transactionLog(self, first, last):
         return self.__undoLog(first, last, with_oids=True)
 
-    def history(self, oid, version=None, length=1, filter=None, object_only=0):
+    def history(self, oid, version=None, size=1, filter=None, object_only=0):
         # Get history informations for object first
         cell_list = self._getCellListForOID(oid, readable=True)
         shuffle(cell_list)
@@ -890,7 +890,7 @@
 
             self.local_var.history = None
             try:
-                self._askStorage(conn, Packets.AskObjectHistory(oid, 0, length))
+                self._askStorage(conn, Packets.AskObjectHistory(oid, 0, size))
             except ConnectionClosed:
                 continue