[Erp5-report] r46002 arnaud.fontaine - /erp5/trunk/utils/erp5.utils.test_browser/src/erp5/u...

nobody at svn.erp5.org nobody at svn.erp5.org
Mon Aug 29 09:22:30 CEST 2011


Author: arnaud.fontaine
Date: Mon Aug 29 09:22:30 2011
New Revision: 46002

URL: http://svn.erp5.org?rev=46002&view=rev
Log:
No need to bind lastRequestPystones as everything is in seconds now and can be
later converted to pystones by calling browser.timer.pystonesPerSecond() on a
Browser instance.

With the previous commit, it allows to have shorter and nicer method names.

Modified:
    erp5/trunk/utils/erp5.utils.test_browser/src/erp5/utils/test_browser/browser.py

Modified: erp5/trunk/utils/erp5.utils.test_browser/src/erp5/utils/test_browser/browser.py
URL: http://svn.erp5.org/erp5/trunk/utils/erp5.utils.test_browser/src/erp5/utils/test_browser/browser.py?rev=46002&r1=46001&r2=46002&view=diff
==============================================================================
--- erp5/trunk/utils/erp5.utils.test_browser/src/erp5/utils/test_browser/browser.py [utf8] (original)
+++ erp5/trunk/utils/erp5.utils.test_browser/src/erp5/utils/test_browser/browser.py [utf8] Mon Aug 29 09:22:30 2011
@@ -50,8 +50,8 @@ def measurementMetaClass(prefix):
   class MeasurementMetaClass(type):
     """
     Meta class to automatically wrap methods whose prefix starts with
-    C{prefix}, and also to define C{lastRequestSeconds} and
-    C{lastRequestPystones} on other classes besides of Browser.
+    C{prefix}, and also to define C{lastRequestSeconds} on other classes
+    besides of Browser.
     """
     def __new__(metacls, name, bases, dictionary):
       def timeInSecondDecorator(method):
@@ -92,20 +92,15 @@ def measurementMetaClass(prefix):
           if callable(attribute):
             applyMeasure(attribute)
 
-      # lastRequestSeconds and lastRequestPystones properties are only
-      # defined on classes inheriting from zope.testbrowser.browser.Browser,
-      # so create these properties for all other classes too
+      # lastRequestSeconds properties are only defined on classes inheriting
+      # from zope.testbrowser.browser.Browser, so create these properties for
+      # all other classes too
       if 'Browser' not in bases[0].__name__:
         time_method = lambda self: self.browser.lastRequestSeconds
         time_method.func_name = 'lastRequestSeconds'
         time_method.__doc__ = Browser.lastRequestSeconds.__doc__
         dictionary['lastRequestSeconds'] = property(time_method)
 
-        time_method = lambda self: self.browser.lastRequestPystones
-        time_method.func_name = 'lastRequestPystones'
-        time_method.__doc__ = Browser.lastRequestPystones.__doc__
-        dictionary['lastRequestPystones'] = property(time_method)
-
       return super(MeasurementMetaClass,
                    metacls).__new__(metacls, name, bases, dictionary)
 



More information about the Erp5-report mailing list