[Erp5-report] r45021 rafael - /erp5/trunk/products/ERP5Configurator/Document/

[nobody at svn.erp5.org]

Author: rafael
Date: Sat Apr  2 00:42:06 2011
New Revision: 45021

URL: http://svn.erp5.org?rev=45021&view=rev
Log:
Improve code.

Modified:
    erp5/trunk/products/ERP5Configurator/Document/ServiceConfiguratorItem.py

Modified: erp5/trunk/products/ERP5Configurator/Document/ServiceConfiguratorItem.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Configurator/Document/ServiceConfiguratorItem.py?rev=45021&r1=45020&r2=45021&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Configurator/Document/ServiceConfiguratorItem.py [utf8] (original)
+++ erp5/trunk/products/ERP5Configurator/Document/ServiceConfiguratorItem.py [utf8] Sat Apr  2 00:42:06 2011
@@ -57,16 +57,11 @@ class ServiceConfiguratorItem(Configurat
 
   def build(self, business_configuration):
     portal = self.getPortalObject()
-    module = portal.service_module
-    # XXX Maybe this approach efficient and scalable.
-    object_id_list = module.objectIds()
     for service_id, service_title in self.getConfigurationList():
-      if service_id not in object_id_list:
-        document = module.newContent(portal_type='Service',
+      document = getattr(portal.service_module, service_id, None)
+      if document is None:
+        document = portal.service_module.newContent(portal_type='Service',
                                    id=service_id,
-                                   title=service_title,
-                                   )
-      else:
-        document = module[service_id]
+                                   title=service_title)
       ## add to customer template
       self.install(document, business_configuration)