[Erp5-report] r44383 jerome - /erp5/trunk/products/ERP5/Document/Movement.py

nobody at svn.erp5.org nobody at svn.erp5.org
Thu Mar 17 14:08:51 CET 2011


Author: jerome
Date: Thu Mar 17 14:08:51 2011
New Revision: 44383

URL: http://svn.erp5.org?rev=44383&view=rev
Log:
return True / False instead of 1 / 0

Modified:
    erp5/trunk/products/ERP5/Document/Movement.py

Modified: erp5/trunk/products/ERP5/Document/Movement.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/Movement.py?rev=44383&r1=44382&r2=44383&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/Movement.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/Movement.py [utf8] Thu Mar 17 14:08:51 2011
@@ -480,9 +480,9 @@ class Movement(XMLObject, Amount, Compos
                              'isConvergent')
   def isConvergent(self):
     """
-      Returns 0 if the target is not met
+      Returns true if movement is not divergent
     """
-    return int(not self.isDivergent())
+    return bool(not self.isDivergent())
 
   security.declareProtected( Permissions.AccessContentsInformation,
                              'isDivergent')
@@ -497,14 +497,14 @@ class Movement(XMLObject, Amount, Compos
     """
     for simulation_movement in self.getDeliveryRelatedValueList():
       if simulation_movement.isDivergent():
-        return 1
-    return 0
+        return True
+    return False
 
   def getDivergenceList(self):
     """
     Return a list of messages that contains the divergences 
     """
-    divergence_list = [] 
+    divergence_list = []
     for simulation_movement in self.getDeliveryRelatedValueList():
       divergence_list.extend(simulation_movement.getDivergenceList())
 



More information about the Erp5-report mailing list