[Erp5-report] r44280 jerome - /erp5/trunk/products/ERP5/Document/ImmobilisableItem.py

nobody at svn.erp5.org nobody at svn.erp5.org
Tue Mar 15 10:03:45 CET 2011


Author: jerome
Date: Tue Mar 15 10:03:45 2011
New Revision: 44280

URL: http://svn.erp5.org?rev=44280&view=rev
Log:
comment out code that claims that ImmobilisableItem implements IExpandableItem,
because they do not have 'expand' method, and because at the time beeing all
Items are subclasses of ImmobilisableItem

Modified:
    erp5/trunk/products/ERP5/Document/ImmobilisableItem.py

Modified: erp5/trunk/products/ERP5/Document/ImmobilisableItem.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/ImmobilisableItem.py?rev=44280&r1=44279&r2=44280&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/ImmobilisableItem.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/ImmobilisableItem.py [utf8] Tue Mar 15 10:03:45 2011
@@ -78,23 +78,27 @@ class ImmobilisableItem(XMLObject, Amoun
                       , PropertySheet.Amortisation
                       )
 
-    zope.interface.implements(interfaces.IExpandableItem,)
-
-    # IExpandableItem interface implementation
-    def getSimulationMovementSimulationState(self, simulation_movement):
-      """Returns the simulation state for this simulation movement.
-      """
-      portal = self.getPortalObject()
-      draft_state_list = portal.getDraftOrderStateList()
-      # if we have an order which is not draft, we'll consider the generated
-      # simulation movement are planned.
-      # This is probably oversimplified implementation, as we may want to look
-      # deliveries / invoices.
-      for movement in self.getAggregateRelatedValueList(
-          portal_type=portal.getPortalOrderMovementTypeList(),):
-        if movement.getSimulationState() not in draft_state_list:
-          return 'planned'
-      return 'draft'
+    # FIXME: ImmobilisableItem have to implement IExpandableItem, but they do
+    # not have 'expand' method at the time beeing, simulation methods used here
+    # have different names.
+
+##     zope.interface.implements(interfaces.IExpandableItem,)
+## 
+##     # IExpandableItem interface implementation
+##     def getSimulationMovementSimulationState(self, simulation_movement):
+##       """Returns the simulation state for this simulation movement.
+##       """
+##       portal = self.getPortalObject()
+##       draft_state_list = portal.getDraftOrderStateList()
+##       # if we have an order which is not draft, we'll consider the generated
+##       # simulation movement are planned.
+##       # This is probably oversimplified implementation, as we may want to look
+##       # deliveries / invoices.
+##       for movement in self.getAggregateRelatedValueList(
+##           portal_type=portal.getPortalOrderMovementTypeList(),):
+##         if movement.getSimulationState() not in draft_state_list:
+##           return 'planned'
+##       return 'draft'
 
     security.declareProtected(Permissions.AccessContentsInformation,
                               'getImmobilisationRelatedMovementList')



More information about the Erp5-report mailing list