[Erp5-report] r42431 jerome - /erp5/trunk/products/ERP5/tests/testXHTML.py

[nobody at svn.erp5.org]

Author: jerome
Date: Tue Jan 18 18:25:03 2011
New Revision: 42431

URL: http://svn.erp5.org?rev=42431&view=rev
Log:
readability

Modified:
    erp5/trunk/products/ERP5/tests/testXHTML.py

Modified: erp5/trunk/products/ERP5/tests/testXHTML.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/tests/testXHTML.py?rev=42431&r1=42430&r2=42431&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/tests/testXHTML.py [utf8] (original)
+++ erp5/trunk/products/ERP5/tests/testXHTML.py [utf8] Tue Jan 18 18:25:03 2011
@@ -333,17 +333,15 @@ class TestXHTML(ERP5TypeTestCase):
     """Make sure that preference view is not duplicated."""
     preference_view_id_dict = {}
     def addPreferenceView(folder_id, view_id):
-      if not view_id in preference_view_id_dict:
-        preference_view_id_dict[view_id] = []
-      preference_view_id_dict[view_id].append('%s.%s' % (folder_id, view_id))
+      preference_view_id_dict.setdefault(view_id, []).append('%s.%s' % (folder_id, view_id))
     error_list = []
-    for object_ in self.portal.portal_skins.objectValues():
-      if object_.isPrincipiaFolderish:
+    for skin_folder in self.portal.portal_skins.objectValues():
+      if skin_folder.isPrincipiaFolderish:
         for id_ in object_.objectIds():
           if id_.startswith('Preference_view'):
-            addPreferenceView(object_.id, id_)
+            addPreferenceView(skin_folder.id, id_)
     for view_id, location_list in preference_view_id_dict.items():
-      if len(location_list)>1:
+      if len(location_list) > 1:
         error_list.extend(location_list)
     self.assertEqual(error_list, [])