[Erp5-report] r40096 luke - /erp5/trunk/buildout/tests/assertSoftware.py

nobody at svn.erp5.org nobody at svn.erp5.org
Tue Nov 9 13:47:26 CET 2010


Author: luke
Date: Tue Nov  9 13:47:25 2010
New Revision: 40096

URL: http://svn.erp5.org?rev=40096&view=rev
Log:
 - change method name and add docstring as requested

Modified:
    erp5/trunk/buildout/tests/assertSoftware.py

Modified: erp5/trunk/buildout/tests/assertSoftware.py
URL: http://svn.erp5.org/erp5/trunk/buildout/tests/assertSoftware.py?rev=40096&r1=40095&r2=40096&view=diff
==============================================================================
--- erp5/trunk/buildout/tests/assertSoftware.py [utf8] (original)
+++ erp5/trunk/buildout/tests/assertSoftware.py [utf8] Tue Nov  9 13:47:25 2010
@@ -29,10 +29,8 @@
 import unittest
 import sys, os, tempfile, stat, subprocess
 
-def createCleanList(s):
-  """
-    TODO: Add doc string.
-  """
+def getCleanList(s):
+  """Converts free form string separated by whitespaces to python list"""
   return sorted([q.strip() for q in s.split() if len(q.strip()) > 0])
 
 def readElfAsDict(f):
@@ -90,10 +88,10 @@ print sys.version_info[:2]
 
   def test_required_libraries(self):
     """Checks possiblity of importing libraries"""
-    ignored_library_list = createCleanList("""
+    ignored_library_list = getCleanList("""
       socks
     """)
-    required_library_list = createCleanList("""
+    required_library_list = getCleanList("""
       ERP5Diff
       MySQLdb
       SOAPpy
@@ -240,7 +238,7 @@ class AssertApache(unittest.TestCase):
 
   def test_modules(self):
     """Checks for availability of apache modules"""
-    required_module_list = createCleanList("""
+    required_module_list = getCleanList("""
       authn_default_module
       log_config_module
       proxy_http_module




More information about the Erp5-report mailing list