[Erp5-report] r39392 yo - /erp5/trunk/products/ERP5Type/Dynamic/

nobody at svn.erp5.org nobody at svn.erp5.org
Wed Oct 20 13:40:16 CEST 2010


Author: yo
Date: Wed Oct 20 13:40:15 2010
New Revision: 39392

URL: http://svn.erp5.org?rev=39392&view=rev
Log:
Mark bad names that must be fixed.

Modified:
    erp5/trunk/products/ERP5Type/Dynamic/lazyclass.py
    erp5/trunk/products/ERP5Type/Dynamic/portaltypeclass.py

Modified: erp5/trunk/products/ERP5Type/Dynamic/lazyclass.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/Dynamic/lazyclass.py?rev=39392&r1=39391&r2=39392&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/Dynamic/lazyclass.py [utf8] (original)
+++ erp5/trunk/products/ERP5Type/Dynamic/lazyclass.py [utf8] Wed Oct 20 13:40:15 2010
@@ -3,6 +3,7 @@ from ExtensionClass import Base as Exten
 
 from zLOG import LOG, ERROR, BLATHER
 
+# FIXME: bad name
 def lazyclass(name, portal_type_class_attr_getter):
     def load(self, attr):
         klass = None

Modified: erp5/trunk/products/ERP5Type/Dynamic/portaltypeclass.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/Dynamic/portaltypeclass.py?rev=39392&r1=39391&r2=39392&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/Dynamic/portaltypeclass.py [utf8] (original)
+++ erp5/trunk/products/ERP5Type/Dynamic/portaltypeclass.py [utf8] Wed Oct 20 13:40:15 2010
@@ -42,6 +42,7 @@ from Products.ERP5Type import PropertySh
 from ExtensionClass import Base as ExtensionBase
 from zLOG import LOG, ERROR, INFO
 
+# FIXME: bad name
 def _import_class(classpath):
   try:
     module_path, class_name = classpath.rsplit('.', 1)
@@ -56,6 +57,7 @@ def _import_class(classpath):
   except StandardError:
     raise ImportError('Could not import document class %s' % classpath)
 
+# FIXME: bad name
 def _create_accessor_holder_class(property_sheet_tool,
                                   property_sheet_module,
                                   property_sheet_name):
@@ -64,6 +66,7 @@ def _create_accessor_holder_class(proper
   generate its accessor holder
   """
 
+# FIXME: bad name
 def _fill_accessor_holder_list(accessor_holder_list,
                                create_accessor_holder_func,
                                property_sheet_name_set,
@@ -101,6 +104,7 @@ def _fill_accessor_holder_list(accessor_
             "Created accessor holder for %s in %s" % (property_sheet_name,
                                                       accessor_holder_module))
 
+# FIXME: bad name
 def portal_type_factory(portal_type_name):
   """
   Given a portal type, look up in Types Tool the corresponding
@@ -224,6 +228,7 @@ def initializeDynamicModules():
   XXX: there should be only one accessor_holder once the code is
        stable and all the Property Sheets have been migrated
   """
+  # FIXME: bad name
   def portal_type_loader(portal_type_name):
     """
     Returns a lazily-loaded "portal-type as a class"
@@ -245,6 +250,7 @@ def initializeDynamicModules():
 
   erp5.portal_type = portal_type_container
 
+  # FIXME: bad name
   def temp_portal_type_loader(portal_type_name):
     """
     Returns a class suitable for a temporary portal type
@@ -280,6 +286,7 @@ def initializeDynamicModules():
   erp5.temp_portal_type = dynamicmodule.dynamicmodule('erp5.temp_portal_type',
                                                    temp_portal_type_loader)
 
+# FIXME: bad name
 def _clear_accessor_holder_module(module):
   """
   Clear the given accessor holder module (either for filesystem or




More information about the Erp5-report mailing list