[Erp5-report] r39387 yo - /erp5/trunk/products/ERP5Type/Dynamic/

nobody at svn.erp5.org nobody at svn.erp5.org
Wed Oct 20 13:22:53 CEST 2010


Author: yo
Date: Wed Oct 20 13:22:52 2010
New Revision: 39387

URL: http://svn.erp5.org?rev=39387&view=rev
Log:
Remove bogus print_stack calls. Do not catch all exceptions, otherwise you cannot even stop infinite loops with Ctrl-C!

Modified:
    erp5/trunk/products/ERP5Type/Dynamic/lazyclass.py
    erp5/trunk/products/ERP5Type/Dynamic/portaltypeclass.py

Modified: erp5/trunk/products/ERP5Type/Dynamic/lazyclass.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/Dynamic/lazyclass.py?rev=39387&r1=39386&r2=39387&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/Dynamic/lazyclass.py [utf8] (original)
+++ erp5/trunk/products/ERP5Type/Dynamic/lazyclass.py [utf8] Wed Oct 20 13:22:52 2010
@@ -19,7 +19,7 @@ def lazyclass(name, portal_type_class_at
         portal_type = klass.__name__
         try:
           baseclasses, attributes = portal_type_class_attr_getter(portal_type)
-        except:
+        except AttributeError:
           LOG("ERP5Type.Dynamic", ERROR,
               "Could not access Portal Type Object for type %s" % name)
           import traceback; traceback.print_exc()

Modified: erp5/trunk/products/ERP5Type/Dynamic/portaltypeclass.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/Dynamic/portaltypeclass.py?rev=39387&r1=39386&r2=39387&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/Dynamic/portaltypeclass.py [utf8] (original)
+++ erp5/trunk/products/ERP5Type/Dynamic/portaltypeclass.py [utf8] Wed Oct 20 13:22:52 2010
@@ -53,8 +53,7 @@ def _import_class(classpath):
     InitializeClass(klass)
 
     return klass
-  except:
-    import traceback; traceback.print_exc()
+  except StandardError:
     raise ImportError('Could not import document class %s' % classpath)
 
 def _create_accessor_holder_class(property_sheet_tool,
@@ -123,7 +122,6 @@ def portal_type_factory(portal_type_name
   try:
     portal_type = getattr(type_tool, portal_type_name)
   except:
-    import traceback; traceback.print_stack()
     raise AttributeError('portal type %s not found in Types Tool' \
                             % portal_type_name)
 




More information about the Erp5-report mailing list