[Erp5-report] r38212 yo - /erp5/trunk/products/ERP5/Document/OrderBuilder.py

[nobody at svn.erp5.org]

Author: yo
Date: Thu Sep  9 09:59:54 2010
New Revision: 38212

URL: http://svn.erp5.org?rev=38212&view=rev
Log:
Use set instead of dict for readability.

Modified:
    erp5/trunk/products/ERP5/Document/OrderBuilder.py

Modified: erp5/trunk/products/ERP5/Document/OrderBuilder.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/OrderBuilder.py?rev=38212&r1=38211&r2=38212&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/OrderBuilder.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/OrderBuilder.py [utf8] Thu Sep  9 09:59:54 2010
@@ -543,13 +543,10 @@ class OrderBuilder(XMLObject, Amount, Pr
         return
 
       # Update variation category list on line
-      variation_category_dict = dict([(variation_category, True) for
-                                      variation_category in
-                                      delivery_line.getVariationCategoryList()])
+      variation_category_set = set(delivery_line.getVariationCategoryList())
       for movement in movement_group_node.getMovementList():
-        for category in movement.getVariationCategoryList():
-          variation_category_dict[category] = True
-      variation_category_list = sorted(variation_category_dict.keys())
+        variation_category_set.update(movement.getVariationCategoryList())
+      variation_category_list = sorted(variation_category_set)
       delivery_line.setVariationCategoryList(variation_category_list)
       # Then, create delivery movement (delivery cell or complete delivery
       # line)