[Erp5-report] r38182 yo - /erp5/trunk/products/ERP5/Document/OrderBuilder.py

[nobody at svn.erp5.org]

Author: yo
Date: Wed Sep  8 07:41:33 2010
New Revision: 38182

URL: http://svn.erp5.org?rev=38182&view=rev
Log:
Remove useless parts from build, and add a comment about inconsistency about security handling.

Modified:
    erp5/trunk/products/ERP5/Document/OrderBuilder.py

Modified: erp5/trunk/products/ERP5/Document/OrderBuilder.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/OrderBuilder.py?rev=38182&r1=38181&r2=38182&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/OrderBuilder.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/OrderBuilder.py [utf8] Wed Sep  8 07:41:33 2010
@@ -107,24 +107,23 @@ class OrderBuilder(XMLObject, Amount, Pr
       or to Simulation Movements related to a limited set of existing
     """
     # Parameter initialization
-    if movement_relative_url_list is None:
-      movement_relative_url_list = []
     if delivery_relative_url_list is None:
       delivery_relative_url_list = []
-    if movement_list is None:
-      movement_list = []
     # Call a script before building
     self.callBeforeBuildingScript()
     # Select
-    if not len(movement_list):
-      if len(movement_relative_url_list) == 0:
+    if not movement_list:
+      # XXX this code below has a problem of inconsistency in that
+      # searchMovementList is unrestricted while passing a list of
+      # movements is restricted.
+      if not movement_relative_url_list:
         movement_list = self.searchMovementList(
                                         delivery_relative_url_list=delivery_relative_url_list,
                                         applied_rule_uid=applied_rule_uid,**kw)
       else:
         movement_list = [self.restrictedTraverse(relative_url) for relative_url \
                          in movement_relative_url_list]
-    if not len(movement_list):
+    if not movement_list:
       return []
     # Collect
     root_group_node = self.collectMovement(movement_list)