[Erp5-report] r38107 vincent - in /erp5/trunk/bt5/erp5_banking_core: SkinTemplateItem/porta...

[nobody at svn.erp5.org]

Author: vincent
Date: Wed Sep  1 15:04:29 2010
New Revision: 38107

URL: http://svn.erp5.org?rev=38107&view=rev
Log:
Don't check uid accessors after checking value is not None.

This breaks because of monkey-patched baobab uid getters (see
ERP5Banking/Document/BankingOperation.py) in case where we are not interested
in uids (ex: Cash Container Cell). The only cases it should detect should in
fact be detected in unit tests (ie, stock impact invalid for a certain kind of
document).
Reverts partially r18818.

Modified:
    erp5/trunk/bt5/erp5_banking_core/SkinTemplateItem/portal_skins/erp5_banking_core/Base_checkBaobabSourceAndDestination.xml
    erp5/trunk/bt5/erp5_banking_core/bt/revision

Modified: erp5/trunk/bt5/erp5_banking_core/SkinTemplateItem/portal_skins/erp5_banking_core/Base_checkBaobabSourceAndDestination.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_banking_core/SkinTemplateItem/portal_skins/erp5_banking_core/Base_checkBaobabSourceAndDestination.xml?rev=38107&r1=38106&r2=38107&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_banking_core/SkinTemplateItem/portal_skins/erp5_banking_core/Base_checkBaobabSourceAndDestination.xml [utf8] (original)
+++ erp5/trunk/bt5/erp5_banking_core/SkinTemplateItem/portal_skins/erp5_banking_core/Base_checkBaobabSourceAndDestination.xml [utf8] Wed Sep  1 15:04:29 2010
@@ -72,14 +72,6 @@ for object in object_to_check_list:\n
         context.log(\'Error on \', (context.getRelativeUrl(),node_url))\n
         msg = Message(domain=\'ui\',message=\'Sorry, wrong source or destination\')\n
         raise ValidationFailed, (msg,)\n
-  if baobab_source is not None and object.getBaobabSourceUid() is None:\n
-    context.log(\'Error on \', (context.getRelativeUrl(),baobab_source))\n
-    msg = Message(domain=\'ui\',message=\'Sorry, wrong source or destination\')\n
-    raise ValidationFailed, (msg,)\n
-  if baobab_destination is not None and object.getBaobabDestinationUid() is None:\n
-    context.log(\'Error on \', (context.getRelativeUrl(),baobab_destination))\n
-    msg = Message(domain=\'ui\',message=\'Sorry, wrong source or destination\')\n
-    raise ValidationFailed, (msg,)\n
 </string> </value>
         </item>
         <item>

Modified: erp5/trunk/bt5/erp5_banking_core/bt/revision
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_banking_core/bt/revision?rev=38107&r1=38106&r2=38107&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_banking_core/bt/revision [utf8] (original)
+++ erp5/trunk/bt5/erp5_banking_core/bt/revision [utf8] Wed Sep  1 15:04:29 2010
@@ -1 +1 @@
-543
+544