[Erp5-report] r37261 yo - in /erp5/trunk/bt5/erp5_base: SkinTemplateItem/portal_skins/erp5_...

[nobody at svn.erp5.org]

Author: yo
Date: Sat Jul 24 02:42:13 2010
New Revision: 37261

URL: http://svn.erp5.org?rev=37261&view=rev
Log:
2010-07-24 yo
* Fix the bug that generates multiple Root Applied Rules partially. Ultimately, we should always use the same script (i.e. Delivery_updateSimulation), otherwise it is too hard to make sure that all callers are serialized.

Modified:
    erp5/trunk/bt5/erp5_base/SkinTemplateItem/portal_skins/erp5_base/Delivery_updateSimulation.xml
    erp5/trunk/bt5/erp5_base/bt/change_log
    erp5/trunk/bt5/erp5_base/bt/revision

Modified: erp5/trunk/bt5/erp5_base/SkinTemplateItem/portal_skins/erp5_base/Delivery_updateSimulation.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_base/SkinTemplateItem/portal_skins/erp5_base/Delivery_updateSimulation.xml?rev=37261&r1=37260&r2=37261&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_base/SkinTemplateItem/portal_skins/erp5_base/Delivery_updateSimulation.xml [utf8] (original)
+++ erp5/trunk/bt5/erp5_base/SkinTemplateItem/portal_skins/erp5_base/Delivery_updateSimulation.xml [utf8] Sat Jul 24 02:42:13 2010
@@ -61,15 +61,24 @@ tag = delivery_path + \'_updateAppliedRu
 \n
 priority = 3\n
 \n
+# These parameters are passed to activate for expand and reindexObject,\n
+# so Delivery_updateAppliedRule will wait for the creation and indexing of\n
+# Applied Rules and Simulation Movements by another Delivery_updateAppliedRule.\n
+# This is required for finding an existing Applied Rule by the catalog, and\n
+# avoiding needless conflicts.\n
 activate_kw = { \n
   \'tag\': expand_tag,\n
   \'priority\': priority,\n
 }\n
+\n
+# Serialization is required for avoiding parallel executions of updateAppliedRule\n
+# which may generate multiple Root Applied Rules.\n
 delivery.activate(\n
     after_path_and_method_id=path_and_method_id,\n
     after_tag=expand_tag,\n
     tag=tag,\n
     priority=priority,\n
+    serialization_tag=delivery_path,\n
     ).Delivery_updateAppliedRule(activate_kw=activate_kw)\n
 </string> </value>
         </item>

Modified: erp5/trunk/bt5/erp5_base/bt/change_log
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_base/bt/change_log?rev=37261&r1=37260&r2=37261&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_base/bt/change_log [utf8] (original)
+++ erp5/trunk/bt5/erp5_base/bt/change_log [utf8] Sat Jul 24 02:42:13 2010
@@ -1,3 +1,6 @@
+2010-07-24 yo
+* Fix the bug that generates multiple Root Applied Rules partially. Ultimately, we should always use the same script (i.e. Delivery_updateSimulation), otherwise it is too hard to make sure that all callers are serialized.
+
 2010-07-14 yusei
 * Set reference field to Rounding Model view form.
 

Modified: erp5/trunk/bt5/erp5_base/bt/revision
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_base/bt/revision?rev=37261&r1=37260&r2=37261&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_base/bt/revision [utf8] (original)
+++ erp5/trunk/bt5/erp5_base/bt/revision [utf8] Sat Jul 24 02:42:13 2010
@@ -1 +1 @@
-815
\ No newline at end of file
+816
\ No newline at end of file