[Erp5-report] r34799 fabien - in /erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style: Skin...

[nobody at svn.erp5.org]

Author: fabien
Date: Tue Apr 27 10:15:51 2010
New Revision: 34799

URL: http://svn.erp5.org?rev=34799&view=rev
Log:
there was a mistake in r34739, just fix it.
Using id change a bit the behaviour and can bring new small ambiguities :
- If the web developer create manually a fieldset containing one of the class ('right', 'left'), the javascript will try to create the table containing the fieldset
- if the web developer create a fieldset with name 'center_left' and an extra class 'right'  (using parenthesis in the group name), the javascript will position the fieldset on the right side.
This cases should be very rare (second one is like a mistake). This problem could be avoided by changing template and css to not use javasacript to position elements (I think that this could be made using pure HTML + CSS).

Modified:
    erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/erp5.js.xml
    erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/bt/revision

Modified: erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/erp5.js.xml
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/erp5.js.xml?rev=34799&r1=34798&r2=34799&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/erp5.js.xml [utf8] (original)
+++ erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_xhtml_style/erp5.js.xml [utf8] Tue Apr 27 10:15:51 2010
@@ -149,26 +149,14 @@
   }\n
 }\n
 \n
-function matchChunk(string, separator, chunk_value) {\n
-  if (string != null) {\n
-    var chunk_list = string.split(separator);\n
-    var i;\n
-    for (i = 0; i < chunk_list.length; i++) {\n
-      if (chunk_list[i] == chunk_value)\n
-        return true;\n
-    }\n
-  }\n
-  return false;\n
-}\n
-\n
 function matchLeftFieldset(element) {\n
-  return (element.tagName == "FIELDSET") &&\n
-          matchChunk(element.className, \' \', "left");\n
+  return (element.tagName == "FIELDSET" &&\n
+       element.className.toLowerCase().indexOf(\'left\') != -1)\n
 }\n
 \n
 function matchRightFieldset(element, ignored) {\n
-  if ((element.tagName == "FIELDSET") &&\n
-       matchChunk(element.className, \' \', "right"))\n
+  if (element.tagName == "FIELDSET" &&\n
+       element.className.toLowerCase().indexOf(\'right\') != -1)\n
     return 7; /* End row, table and use element */\n
   return 0;\n
 }\n

Modified: erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/bt/revision
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/bt/revision?rev=34799&r1=34798&r2=34799&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/bt/revision [utf8] (original)
+++ erp5/trunk/products/ERP5/bootstrap/erp5_xhtml_style/bt/revision [utf8] Tue Apr 27 10:15:51 2010
@@ -1,1 +1,1 @@
-931
+933